-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inject meta tags in Tracing-without-Performance-mode #8520
Comments
@AbhiPrasad What exactly needs to be done here? I would like to do this for Next.js but don't fully understand the task. |
Right now we only inject meta tags if there is a sampled transaction/span. It would be great if we can remove this condition and inject meta tags based on the propagation context. Same conditional logic like we have for undici: sentry-javascript/packages/node/src/integrations/undici/index.ts Lines 175 to 185 in 530f786
|
Got it. Thanks! |
@AbhiPrasad I wonder if this will screw with the trace view in replays a lot. This would essentially cause browser sessions of multiple different users to be grouped together under one server process 🤔 Maybe this is not what we want at all... |
Closing this because it has been implemented |
Extracted from #8352 as standalone task. Make sure tracing without performance works for injecting meta tags.
We should gate this with a new boolean option.
Tasks
getTraceData
function #13134getTraceMetaTags
function #13201The text was updated successfully, but these errors were encountered: