Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@sentry/nextjs peerDependencies doesn't include Next.js 14 #9380

Closed
3 tasks done
ianschmitz opened this issue Oct 26, 2023 · 4 comments · Fixed by #9390
Closed
3 tasks done

@sentry/nextjs peerDependencies doesn't include Next.js 14 #9380

ianschmitz opened this issue Oct 26, 2023 · 4 comments · Fixed by #9390
Labels
Package: browser Issues related to the Sentry Browser SDK Type: Bug

Comments

@ianschmitz
Copy link

ianschmitz commented Oct 26, 2023

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/nextjs

SDK Version

7.75.1

Framework Version

14.0.0

Link to Sentry event

No response

SDK Setup

No response

Steps to Reproduce

Try to install the package while using next@14.0.0

Expected Result

No npm install errors

Actual Result

npm ERR!
 While resolving: undefined@undefined
npm ERR! Found: next@14.0.0
npm ERR! node_modules/next
npm ERR!   next@"^14.0.0" from the root project
npm
 ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer next@"^10.0.8 || ^11.0 || ^12.0 || ^13.0" from @sentry/nextjs@7.75.1
npm ERR! node_modules/@sentry/nextjs
npm ERR!   @sentry/nextjs@"^7.75.1" from the root project
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Oct 26, 2023
@github-actions github-actions bot added the Package: browser Issues related to the Sentry Browser SDK label Oct 26, 2023
@AbhiPrasad
Copy link
Member

Will be fixed by #9379!

Give us a bit to confirm that everything works as expected, we have to parse through this changelog 😓 https://github.com/vercel/next.js/releases/tag/v14.0.0

@ADTC
Copy link

ADTC commented Oct 27, 2023

Hi @AbhiPrasad I came here because of hitting the same issue. Thank you for working on this. Hopefully a fix is released soon. How do I update to the fixed version? Just npm update will do?

Also I'm wondering why we need to repeat this fix every time there's a new major version of Next.js?

@AbhiPrasad
Copy link
Member

@ADTC Once the new version of the SDK is out, npm update is the way to go!

Also I'm wondering why we need to repeat this fix every time there's a new major version of Next.js?

It's not necessarily a fix, it's more like a feature. A new major version of a framework means that underlying APIs or architecture could change, and we want to make sure the Sentry SDK is compatible with all of those changes before saying our SDK supports Next 14.

It would be irresponsible on our side to say we support any future major versions of Next.js without taking the time to test things and fully validate. We want to make sure error/performance/session replay/cron monitoring all works as intended! Sometimes we've even helped validate bugs in Next.js themselves.

usually we have max 2-3 day turnaround between a new Next.js version releasing and us doing a SDK release, so appreciate the patience in the mean time.

@AbhiPrasad AbhiPrasad mentioned this issue Oct 27, 2023
3 tasks
@AbhiPrasad
Copy link
Member

Released with https://github.com/getsentry/sentry-javascript/releases/tag/7.76.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: browser Issues related to the Sentry Browser SDK Type: Bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants