From 79d7297c60aa824c8e96d15d21823bfb8890aa7c Mon Sep 17 00:00:00 2001 From: Daniel Griesser Date: Thu, 14 May 2020 10:23:04 +0200 Subject: [PATCH 1/3] fix: Use proper type name for op --- packages/apm/src/integrations/tracing.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/apm/src/integrations/tracing.ts b/packages/apm/src/integrations/tracing.ts index f2eb1975a57c..13560628c8bf 100644 --- a/packages/apm/src/integrations/tracing.ts +++ b/packages/apm/src/integrations/tracing.ts @@ -493,8 +493,8 @@ export class Tracing implements Integration { case 'paint': case 'measure': const mark = transactionSpan.child({ - description: `${entry.entryType} ${entry.name}`, - op: 'mark', + description: `${entry.name}`, + op: entry.entryType, }); mark.startTimestamp = timeOrigin + startTime; mark.timestamp = mark.startTimestamp + duration; From 5b2f378a542f1fa3610ce7f6ffda22dbdd603395 Mon Sep 17 00:00:00 2001 From: Daniel Griesser Date: Thu, 14 May 2020 10:24:50 +0200 Subject: [PATCH 2/3] chore: Changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 19f20acc4520..2e09a97cdc37 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,8 @@ - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott +- [apm] fix: Use proper type name for op #2584 + ## 5.16.0 - [core] feat: Send transactions in envelopes (#2553) From 18dd819a888b0b2d32a6a6f9d61abad9ea449d2a Mon Sep 17 00:00:00 2001 From: Daniel Griesser Date: Thu, 14 May 2020 10:33:22 +0200 Subject: [PATCH 3/3] ref: CodeReview --- packages/apm/src/integrations/tracing.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/apm/src/integrations/tracing.ts b/packages/apm/src/integrations/tracing.ts index 13560628c8bf..33f1b3295368 100644 --- a/packages/apm/src/integrations/tracing.ts +++ b/packages/apm/src/integrations/tracing.ts @@ -493,7 +493,7 @@ export class Tracing implements Integration { case 'paint': case 'measure': const mark = transactionSpan.child({ - description: `${entry.name}`, + description: entry.name, op: entry.entryType, }); mark.startTimestamp = timeOrigin + startTime;