Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integerations/Offline: Remove false positive #2890

Merged
merged 2 commits into from
Sep 14, 2020

Conversation

piotr-cz
Copy link
Contributor

The Hub.captureEvent method always returns new event ID, so event will always be purged from event store (even that client failed to send it).


Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@kamilogorek kamilogorek merged commit 15465a8 into getsentry:master Sep 14, 2020
@kamilogorek
Copy link
Contributor

Thanks!

@piotr-cz piotr-cz deleted the cs/remove-false-positive branch September 14, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants