From 425ed478d3e3c78caefcbea984661aa0c1f0049e Mon Sep 17 00:00:00 2001 From: Nicholas Wylie Date: Mon, 15 Nov 2021 13:47:54 +1100 Subject: [PATCH] Don't special case DOMExceptions that are also Errors --- packages/browser/src/eventbuilder.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/browser/src/eventbuilder.ts b/packages/browser/src/eventbuilder.ts index c3734c9c39e6..2a94476f2155 100644 --- a/packages/browser/src/eventbuilder.ts +++ b/packages/browser/src/eventbuilder.ts @@ -7,6 +7,7 @@ import { isError, isErrorEvent, isEvent, + isInstanceOf, isPlainObject, SyncPromise, } from '@sentry/utils'; @@ -73,7 +74,10 @@ export function eventFromUnknownInput( event = eventFromStacktrace(computeStackTrace(exception as Error)); return event; } - if (isDOMError(exception as DOMError) || isDOMException(exception as DOMException)) { + if ( + isDOMError(exception as DOMError) || + (isDOMException(exception as DOMException) && !isInstanceOf(exception, Error)) + ) { // If it is a DOMError or DOMException (which are legacy APIs, but still supported in some browsers) // then we just extract the name, code, and message, as they don't provide anything else // https://developer.mozilla.org/en-US/docs/Web/API/DOMError