Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(browser): Use ratelimit utils in base transport #4686

Merged
merged 14 commits into from
Mar 14, 2022

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Mar 4, 2022

Ref #4660

This PR converts the browser based transport to use the ratelimit helpers introduced in #4685.

This is primarily used to validate if the helpers will work properly, but also should provide some bundle size wins. nvm I guess RIP.

Resolves https://getsentry.atlassian.net/browse/WEB-661

@AbhiPrasad AbhiPrasad force-pushed the abhi-rate-limit-browser branch from 18a8a1a to 39842b9 Compare March 4, 2022 16:27
@AbhiPrasad AbhiPrasad force-pushed the abhi-rate-limit-browser branch from 39842b9 to a7a225f Compare March 4, 2022 16:33
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2022

size-limit report

Path Base Size (af7081c) Current Size Change
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.37 KB 19.41 KB +0.19% 🔺
@sentry/browser - ES5 CDN Bundle (minified) 61.92 KB 62.03 KB +0.18% 🔺
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.04 KB 18.06 KB +0.16% 🔺
@sentry/browser - ES6 CDN Bundle (minified) 55.32 KB 55.42 KB +0.19% 🔺
@sentry/browser - Webpack (gzipped + minified) 22.3 KB 22.33 KB +0.16% 🔺
@sentry/browser - Webpack (minified) 76.58 KB 76.67 KB +0.12% 🔺
@sentry/react - Webpack (gzipped + minified) 22.33 KB 22.36 KB +0.16% 🔺
@sentry/nextjs Client - Webpack (gzipped + minified) 46.56 KB 46.57 KB +0.03% 🔺
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.25 KB 25.29 KB +0.14% 🔺
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 23.65 KB 23.67 KB +0.08% 🔺

@AbhiPrasad AbhiPrasad force-pushed the abhi-rate-limit-browser branch from a7a225f to 51d138b Compare March 4, 2022 17:51
Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from abhi-rate-limit-helpers to master March 7, 2022 13:09
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) March 7, 2022 13:18
@AbhiPrasad
Copy link
Member Author

I don't understand why the tests are failing. Will keep at this for another 20-30 min, and then ask for help!

@AbhiPrasad
Copy link
Member Author

god bless I fixed this - the mocks were wrong

@AbhiPrasad AbhiPrasad merged commit 0e15dae into master Mar 14, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-rate-limit-browser branch March 14, 2022 13:41
@AbhiPrasad AbhiPrasad added this to the Pre 7.0.0 Work milestone Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants