-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(browser): Use ratelimit utils in base transport #4686
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
force-pushed
the
abhi-rate-limit-browser
branch
from
March 4, 2022 16:27
18a8a1a
to
39842b9
Compare
AbhiPrasad
force-pushed
the
abhi-rate-limit-browser
branch
from
March 4, 2022 16:33
39842b9
to
a7a225f
Compare
size-limit report
|
AbhiPrasad
force-pushed
the
abhi-rate-limit-browser
branch
from
March 4, 2022 17:51
a7a225f
to
51d138b
Compare
lobsterkatie
approved these changes
Mar 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I don't understand why the tests are failing. Will keep at this for another 20-30 min, and then ask for help! |
god bless I fixed this - the mocks were wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #4660
This PR converts the browser based transport to use the ratelimit helpers introduced in #4685.
This is primarily used to validate if the helpers will work properly,
but also should provide some bundle size wins.nvm I guess RIP.Resolves https://getsentry.atlassian.net/browse/WEB-661