feat(core): Add new transports to base backend #4752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify new transport send by grabbing the envelope category from the envelope instead of passing it in explicitly.
AbhiPrasad
commented
Mar 22, 2022
| this._options._experiments && | ||
| this._options._experiments.newTransport | ||
| ) { | ||
| const api = initAPIDetails(this._options.dsn, this._options._metadata, this._options.tunnel); |
There was a problem hiding this comment.
it's annoying to do this, but considering that the client has access to API, won't be needed in the future!
AbhiPrasad
force-pushed
the
abhi-new-transport-in-client
branch
from
3f8e5b9 to
ea233df
Compare
AbhiPrasad
force-pushed
the
abhi-new-transport-in-client
branch
from
ea233df to
35b0399
Compare
Adds new transports to base backend in core. For now, they are gated behind `options._experiments.newTransport = true`. The next step is to add new transports for fetch, xhr (browser) as well as http, https (node).
AbhiPrasad
force-pushed
the
abhi-new-transport-in-client
branch
from
35b0399 to
2326bb9
Compare
lforst
approved these changes
Mar 23, 2022
size-limit report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4660
Adds new transports to base backend in core. For now, they are gated behind
options._experiments.newTransport = true. The reason this is gated is because client reports does not work with the new transports.The next step is to add new transports for fetch, xhr (browser) as well as http, https (node). We can do this in any order!
This is pretty hacky code, but considering that we are going to remove a lot of this in v7 anyway, I decided to keep this as is. Also no tests because we are moving fast!
Resolves https://getsentry.atlassian.net/browse/WEB-588