Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): Delete RequestSessionStatus enum #4889

Merged
merged 1 commit into from
Apr 8, 2022
Merged

feat(types): Delete RequestSessionStatus enum #4889

merged 1 commit into from
Apr 8, 2022

Conversation

AbhiPrasad
Copy link
Member

See #4888

Deletes the RequestSessionStatus enum that was deprecated in f99bdd1.

Ref: https://getsentry.atlassian.net/browse/WEB-795

@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone Apr 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2022 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.06 KB (-0.38% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 64.28 KB (-0.51% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.77 KB (-0.46% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 57.67 KB (-0.52% 🔽)
@sentry/browser - Webpack (gzipped + minified) 23.05 KB (-0.82% 🔽)
@sentry/browser - Webpack (minified) 80.87 KB (-1.03% 🔽)
@sentry/react - Webpack (gzipped + minified) 23.09 KB (-0.81% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.86 KB (-0.41% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.01 KB (-0.25% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.42 KB (-0.27% 🔽)

@AbhiPrasad AbhiPrasad changed the title feat(types): Delete RequestSessionStatus enum [v7] feat(types): Delete RequestSessionStatus enum Apr 7, 2022
@lobsterkatie lobsterkatie changed the title [v7] feat(types): Delete RequestSessionStatus enum feat(types): Delete RequestSessionStatus enum Apr 7, 2022
@lforst lforst force-pushed the v7-abhi-request-session-status branch from d8a3e48 to 19686ed Compare April 8, 2022 07:55
lforst
lforst approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took the liberty of rebasing this for reviewing. Hope that's alright. Lgtm!

@AbhiPrasad
Copy link
Member Author

Thanks man ❤️

@AbhiPrasad AbhiPrasad merged commit 4bb3c64 into 7.x Apr 8, 2022
@AbhiPrasad AbhiPrasad deleted the v7-abhi-request-session-status branch April 8, 2022 13:59
Lms24 pushed a commit that referenced this pull request Apr 26, 2022
@AbhiPrasad @Lms24
feat(types): Delete RequestSessionStatus enum (#4889)
400670c
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
@AbhiPrasad @lobsterkatie
ref(types): Delete RequestSessionStatus enum (#4889)
c64ca5e
AbhiPrasad added a commit that referenced this pull request May 30, 2022
@AbhiPrasad
ref(types): Delete RequestSessionStatus enum (#4889)
396b567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @lforst