Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(browser): Rename UserAgent integration to HttpContext #5027

Merged
merged 2 commits into from
May 4, 2022

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented May 3, 2022

As suggested in this comment of #2906, this PR renames the Browser UserAgent integration to HttpContext. The reason for doing this is that the integration does more than collecting the user agent information and thus the name wasn't reflecting its entire purpose.

Also added a note in the Migration doc about the change.

Sentry-docs PR: getsentry/sentry-docs#4997

ref: https://getsentry.atlassian.net/browse/WEB-270

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 18.7 KB (-7.15% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 58.42 KB (-9.58% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.51 KB (-7.16% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 52.6 KB (-9.26% 🔽)
@sentry/browser - Webpack (gzipped + minified) 19.21 KB (-17.35% 🔽)
@sentry/browser - Webpack (minified) 62.08 KB (-24.03% 🔽)
@sentry/react - Webpack (gzipped + minified) 19.23 KB (-17.39% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 42.91 KB (-10.72% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 24.52 KB (-5.98% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 23.1 KB (-5.67% 🔽)

@Lms24 Lms24 requested review from lobsterkatie and lforst May 3, 2022 16:18
@Lms24 Lms24 merged commit 1b924e7 into 7.x May 4, 2022
@Lms24 Lms24 deleted the lms-rename-useragent-httpcontext branch May 4, 2022 11:28
@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone May 12, 2022
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
As suggested in this [comment](#2906 (comment)) of #2906, rename the Browser `UserAgent` integration to `HttpContext`. The integration does more than collecting the user agent information and thus the old name wasn't reflecting its entire purpose.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants