Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ref(node): Move non-handler code out of handlers module" #5223

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

AbhiPrasad
Copy link
Member

This PR causes issues with users as reported here: #5222. This is because we added Node library imports in the utils package - which can be consumed in browser contexts.

Reverts #5190

@AbhiPrasad AbhiPrasad requested review from lobsterkatie, a team and Lms24 and removed request for a team June 7, 2022 18:49
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.43 KB (added)
@sentry/browser - ES5 CDN Bundle (minified) 60.2 KB (added)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.24 KB (added)
@sentry/browser - ES6 CDN Bundle (minified) 53.82 KB (added)
@sentry/browser - Webpack (gzipped + minified) 19.99 KB (added)
@sentry/browser - Webpack (minified) 65.19 KB (added)
@sentry/react - Webpack (gzipped + minified) 20.02 KB (added)
@sentry/nextjs Client - Webpack (gzipped + minified) 43.95 KB (added)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.56 KB (added)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.11 KB (added)

@AbhiPrasad AbhiPrasad merged commit 52e945a into master Jun 7, 2022
@AbhiPrasad AbhiPrasad deleted the revert-5190-kmclb-split-up-node-handlers-module branch June 7, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants