Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data truncated in body #63

Closed
chelout opened this issue Apr 20, 2017 · 9 comments
Closed

Data truncated in body #63

chelout opened this issue Apr 20, 2017 · 9 comments

Comments

@chelout
Copy link

chelout commented Apr 20, 2017

While trying to get information about unauthorized webhook, i got truncated data in body section http://joxi.ru/GrqgnBRtQ8OY72 Sentry json http://joxi.ru/DrlVZMdIvJ68M2 has the same issue http://joxi.ru/l2Z6PYwswaYyl2

@ehfeng
Copy link

ehfeng commented May 2, 2017

None of the links point to screenshots. Can you please update?

@ehfeng
Copy link

ehfeng commented May 2, 2017

For context, I spoke with @chelout separately. His main concern is that Array content is not displayed in the stack locals (strings and integers, for example, are). Is it possible we collect and send these as well?

My assumptions is that we're using PHP's default behavior in stringify arrays when we log the error context passed to us and if it's possible to get the Array values.

I don't know enough about the Laravel client to say for sure though.

@chelout
Copy link
Author

chelout commented May 2, 2017

I've updated screenshots links

@dcramer
Copy link
Member

dcramer commented May 2, 2017

@chelout could you confirm the version of sentry/sentry you're using?

@chelout
Copy link
Author

chelout commented May 2, 2017

The latest version

@dcramer
Copy link
Member

dcramer commented May 2, 2017

I wonder if we have the thresholds incorrect. What I believe is happening is its saying "this is recursing too much, just show the Repr version of this instead", which shouldn't be the case here.

@bretthoerner
Copy link

bretthoerner commented May 2, 2017

Yep, our max recursions are 3 which gets you (from his screenshot) data (1), leads (2), and then update (3) at which point we check $_depth < $max_depth and anything that level or lower gets the short serialization.

Do we just want to bump our default levels here or do we do anything smarter in other SDKs? We don't do anything smart in the Java SDK (which I'm familiar with).

@dcramer
Copy link
Member

dcramer commented May 2, 2017

@bretthoerner the original goal was to reflect what the server does, which is semi-dumb, but i think also varies based on the type of data.

@stayallive
Copy link
Collaborator

As per getsentry/sentry-php#554 this limit was increased in sentry/sentry version 1.9.0 which should solve this. Please reopen if it's still an issue with that version of the PHP SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants