Allow fluent use of Transaction::setName() method (#1687)

getsentry · Jan 22, 2024 · 617dde3 · 617dde3
1 parent 29d00b0
commit 617dde3
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/Tracing/Transaction.php b/src/Tracing/Transaction.php
@@ -70,10 +70,14 @@ public function getName(): string
      * Sets the name of this transaction.
      *
      * @param string $name The name
+     *
+     * @return $this
      */
-    public function setName(string $name): void
+    public function setName(string $name): self
     {
         $this->name = $name;
+
+        return $this;
     }
 
     /**

diff --git a/tests/Tracing/TransactionTest.php b/tests/Tracing/TransactionTest.php
@@ -86,6 +86,18 @@ public function testFinishDoesNothingIfSampledFlagIsNotTrue(): void
         $transaction->finish();
     }
 
+    public function testFluentApi(): void
+    {
+        $transaction = new Transaction(TransactionContext::make());
+        $tags = ['foo' => 'bar'];
+        $name = 'baz';
+        $transaction->setTags($tags)
+          ->setName($name)
+          ->finish();
+        $this->assertSame($tags, $transaction->getTags());
+        $this->assertSame($name, $transaction->getName());
+    }
+
     /**
      * @dataProvider parentTransactionContextDataProvider
      */