-
-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.0] Adding the PHP version #562
Comments
I strongly agree. We could initialize the global runtime context with the data or initialize the runtime context of the event as the result will be the same. Alternately, (maybe the clearer option, but also maybe too much over engineered) we could create a specialized middleware |
Ok so #564 already implemented this for 1.x. If we port the tests from there into the 2.x branch we are good! 👍 |
I was thinking, would it make sense to create a |
Yes, very good idea! 👍 |
Closing since this has been implemented in both versions |
A PR was open under the Symfony integration repo (getsentry/sentry-symfony#118) to add the PHP version as a default tag (thanks @hjanuschka !).
I turned it down because I think that this should be done in the base client here. I investigated a bit, and @mitsuhiko told me that there's an already supported context to do that, which looks like this:
IMHO this should target the new client, what do you think?
The text was updated successfully, but these errors were encountered: