Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacktrace and FatalErrorException problem #761

Closed
sztyup opened this issue Feb 1, 2019 · 2 comments
Closed

Stacktrace and FatalErrorException problem #761

sztyup opened this issue Feb 1, 2019 · 2 comments
Milestone

Comments

@sztyup
Copy link
Contributor

sztyup commented Feb 1, 2019

Symfony and Laravel, and probably many other framework uses a Symfony\Component\Debug\Exception\FatalErrorException in its own Fatal error handling process before passing it to Sentry.
The problem is it doesn't return the stacktrace in a standard debug_backtrace format, but replaces the arguments array indexes to the name of the variable if using xdebug.
[args] => Array ( [0] => true )
becomes
[args] => Array ( [variableName] => true )
This causes Sentry\StackTrace::getFrameArgumentsValues function to emit a Warning: A non-numeric value encountered while processing the above Exception. This whole thing makes debugging much more difficult.
If you think this is not edge case enough to warrant a fix, i would be happy to start working on a PR.

@Jean85
Copy link
Collaborator

Jean85 commented Feb 1, 2019

This is not an edge case for sure! We have a beta Laravel SDK in the works, and a Symfony one too.

Please proceed! Tests welcome, obviously!

@ste93cry
Copy link
Collaborator

ste93cry commented Feb 4, 2019

Fixed in #763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants