Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monolog package non dev requirement #908

Closed
TheLevti opened this issue Oct 20, 2019 · 4 comments · Fixed by #916
Closed

Monolog package non dev requirement #908

TheLevti opened this issue Oct 20, 2019 · 4 comments · Fixed by #916
Milestone

Comments

@TheLevti
Copy link
Contributor

Shouldn't be the "monolog/monolog": "^1.3|^2.0", composer requirement in the non-dev section instead? It is clearly used in a class (Sentry\Monolog\Handler) that might be used in production without the dev packages installed.

@Jean85
Copy link
Collaborator

Jean85 commented Oct 20, 2019

That's an optional part of the library, that's why it's not under require. We could add that in the suggest section too to highlight this fact, maybe?

@TheLevti
Copy link
Contributor Author

Ah I understand, makes sense now. Thanks for the clarification.

Yeah why not? I mean if its not too much work of course.

@Jean85
Copy link
Collaborator

Jean85 commented Oct 21, 2019

You're welcome to open a PR yourself if you want!

@TheLevti
Copy link
Contributor Author

No problem, will do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants