-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize span constructor #1274
Conversation
@Jean85 this is a good start, and we can iterate on it after the benchmarks are committed to mainline |
@Ocramius do you agree that we shouldn't put this in CI? In that case, how would you generate a sensible baseline? We would have to re-run them every time manually? |
TBH, having it in CI is generally good value: obviously trouble for older PHP versions, but it doesn't need to run on The reason for having it in CI is not to verify performance, but just to make sure that the benchmarks can still be run, even after years: otherwise, they quickly decay, and become unusable. |
What you can do in CI is running with |
@ste93cry this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a good idea 👍 happy to see you guys diving so deep in the performance 💪
This started as an investigation over #1273. I tried to run PHPBench over the
Span
constructor, and this is the result applying 5f94026:Results seems promising, but the operation seems very small to obtain a consistent bench; @Ocramius any suggestions? You can also try this branch if you want to check if there's an improvement on your profiled test suite.