Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E HTTP client tests #1626

Merged
merged 1 commit into from
Nov 7, 2023
Merged

E2E HTTP client tests #1626

merged 1 commit into from
Nov 7, 2023

Conversation

stayallive
Copy link
Collaborator

This is an attempt on creating E2E HTTP client tests to make sure we send the correct data/headers and also parse a response correctly. We don't need to test with HTTPS and be super fancy since we rely on cURL, we just have to validate we hold cURL correctly basically.

@stayallive stayallive self-assigned this Nov 6, 2023
@stayallive stayallive changed the base branch from master to 4.x November 6, 2023 09:20
@stayallive stayallive force-pushed the e2e-http-client-test branch 2 times, most recently from 18ef516 to 714e65a Compare November 6, 2023 09:34
@stayallive stayallive mentioned this pull request Nov 6, 2023
5 tasks
@stayallive stayallive force-pushed the e2e-http-client-test branch 2 times, most recently from 56da93a to d751702 Compare November 6, 2023 10:07
Base automatically changed from 4.x to master November 6, 2023 10:15
@stayallive stayallive force-pushed the e2e-http-client-test branch 2 times, most recently from ffd5992 to ccf5a42 Compare November 6, 2023 10:19
@stayallive stayallive force-pushed the e2e-http-client-test branch from ccf5a42 to 2e58987 Compare November 6, 2023 13:41
@stayallive stayallive force-pushed the e2e-http-client-test branch from 2e58987 to 43c6770 Compare November 6, 2023 13:52
@stayallive stayallive marked this pull request as ready for review November 6, 2023 13:55
@stayallive stayallive requested a review from cleptric November 6, 2023 13:55
@stayallive stayallive changed the title [4.x] E2E HTTP client tests E2E HTTP client tests Nov 6, 2023
Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪨

@cleptric cleptric merged commit 574d504 into master Nov 7, 2023
33 checks passed
@cleptric cleptric deleted the e2e-http-client-test branch November 7, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants