Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid option name #1627

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Fix invalid option name #1627

merged 1 commit into from
Nov 6, 2023

Conversation

hhamon
Copy link
Contributor

@hhamon hhamon commented Nov 6, 2023

No description provided.

cleptric
cleptric approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😃

@cleptric
Copy link
Member

cleptric commented Nov 6, 2023

Ohh, could you also update https://github.com/getsentry/sentry-php/blob/master/CHANGELOG.md please?

@hhamon
Copy link
Contributor Author

hhamon commented Nov 6, 2023

@cleptric I've updated the other remaining occurrences :)

@hhamon
Copy link
Contributor Author

hhamon commented Nov 6, 2023 •
edited
Loading

@cleptric you should also fix it in the release notes of the tagged version

@cleptric
Copy link
Member

cleptric commented Nov 6, 2023

Already updated 🙂

@cleptric cleptric enabled auto-merge (squash) November 6, 2023 11:43
@cleptric cleptric merged commit 0451278 into getsentry:master Nov 6, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleptric cleptric cleptric approved these changes

Assignees
No one assigned
Labels
Type: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hhamon @cleptric