Handle namespaces for metric_bucket rate limits
#1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleptric
commented
Apr 3, 2024
cleptric
commented
Apr 3, 2024
cleptric
force-pushed
the
metrics-ratelimits
branch
from
31263c6 to
637b69b
Compare
cleptric
force-pushed
the
metrics-ratelimits
branch
from
637b69b to
e8fef31
Compare
jan-auer
approved these changes
Apr 4, 2024
Comment on lines
+63
to
+70
| /** | ||
| * $parameters[0] - retry_after | ||
| * $parameters[1] - categories | ||
| * $parameters[2] - scope (not used) | ||
| * $parameters[3] - reason_code (not used) | ||
| * $parameters[4] - namespaces (only returned if categories contains "metric_bucket"). | ||
| */ | ||
| $parameters = explode(':', $limit, 5); |
There was a problem hiding this comment.
Can you use something like list($retry_after, $categories, ...) here to translate the comment into code? Note that the last few components are optional, though.
There was a problem hiding this comment.
This will fail miserably, if not set 😬
There was a problem hiding this comment.
You can append str_repeat(':', 5) to the $limit so the explode always returns at least 5 parts 😉 Missing entries will be empty strings then.
stayallive
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1726 seemed to simple to be true, and it wasn't 😬
This adds proper handling of metric namespaces. While the SDK does not support adding a namespace to a metric, Relay could reply with a
X-Sentry-Rate-Limitsheader that could contain nonecustomnamespaces, in which case we're still good sending our, inferredcustomnamespaces metrics.Refs getsentry/team-sdks#77