Represent callable strings as strings #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Honestly, how about we consider I feel like we can't do it 100% right anyway (without some very advanced reflection and docblock parsing and even then...) and the false-positive rate is going to be a lot smaller than the current situation. |
mfb
force-pushed
the
callable-strings-logic
branch
from
4617759 to
97712d0
Compare
|
Ok, another take with the simpler logic, representing all callable strings as strings. |
mfb
changed the title
mfb
changed the title
|
Please add a test. |
stayallive
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm honestly not sure what the logic should be here. A simple callable string like "file" I don't think should be assumed to be a callable. But seems a lot more reasonable to represent a callable string containing "::" as callable. Here I also represent callable strings containing an underscore as callables.
Fixes #1734