From 1c5af90e9d017965777bceed7979419198a872ac Mon Sep 17 00:00:00 2001 From: Alessandro Lai Date: Wed, 2 May 2018 17:32:03 +0200 Subject: [PATCH 1/2] Try to use a more reliable way to fatal in regression test --- test/Raven/phpt/fatal_reported_with_async.phpt | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/test/Raven/phpt/fatal_reported_with_async.phpt b/test/Raven/phpt/fatal_reported_with_async.phpt index 01ed9822a..fc7febf59 100644 --- a/test/Raven/phpt/fatal_reported_with_async.phpt +++ b/test/Raven/phpt/fatal_reported_with_async.phpt @@ -41,12 +41,10 @@ register_shutdown_function(function () use (&$client) { } }); -ini_set('memory_limit', '8M'); -while (TRUE) { - $a[] = 'b'; -} +trigger_error('Fatal please!', E_USER_ERROR); ?> --EXPECTF-- -Fatal error: Allowed memory size %s Sending handled fatal error... + +Fatal error: Fatal please! in - on line %d Curl handler successfully emptied From ec33fa918b164cdd03097e9f91ef3756c2246e71 Mon Sep 17 00:00:00 2001 From: Alessandro Lai Date: Wed, 2 May 2018 17:36:25 +0200 Subject: [PATCH 2/2] Fix test expectation under PHP 7.2 --- test/Raven/phpt/fatal_reported_with_async.phpt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/Raven/phpt/fatal_reported_with_async.phpt b/test/Raven/phpt/fatal_reported_with_async.phpt index fc7febf59..3f5ba6e85 100644 --- a/test/Raven/phpt/fatal_reported_with_async.phpt +++ b/test/Raven/phpt/fatal_reported_with_async.phpt @@ -46,5 +46,5 @@ trigger_error('Fatal please!', E_USER_ERROR); --EXPECTF-- Sending handled fatal error... -Fatal error: Fatal please! in - on line %d +Fatal error: Fatal please! in %s on line %d Curl handler successfully emptied