Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opentelemetry): Add entry point for SentryPropagator #3086

Merged

Conversation

mender
Copy link
Contributor

@mender mender commented May 19, 2024

Add entry point for sentry_sdk.integrations.opentelemetry.SentryPropagator. This makes possible to configure opentelemetry using environment variables and add SentryPropagator to existing ones instead of replace them.

Closes #3085

Add entry point for sentry_sdk.integrations.opentelemetry.SentryPropagator.
This makes possible to configure opentelemetry using environment variables
and add SentryPropagator to existing ones instead of replace them.

Closes getsentry#3085
@mender mender force-pushed the entry-points-opentelemetry-propagator branch from 1a7c02a to 5a513fa Compare June 23, 2024 23:13
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the contribution

@sl0thentr0py sl0thentr0py added the Trigger: tests using secrets PR code is safe; run CI label Jul 1, 2024
@github-actions github-actions bot removed the Trigger: tests using secrets PR code is safe; run CI label Jul 1, 2024
@sl0thentr0py sl0thentr0py added the Trigger: tests using secrets PR code is safe; run CI label Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.35%. Comparing base (eab218c) to head (eeaffe1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3086   +/-   ##
=======================================
  Coverage   79.35%   79.35%           
=======================================
  Files         132      132           
  Lines       14218    14218           
  Branches     2985     2985           
=======================================
  Hits        11283    11283           
  Misses       2092     2092           
  Partials      843      843           

see 2 files with indirect coverage changes

@sl0thentr0py sl0thentr0py merged commit 407f651 into getsentry:master Jul 1, 2024
122 of 124 checks passed
@mender mender deleted the entry-points-opentelemetry-propagator branch July 1, 2024 20:19
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this pull request Sep 30, 2024
…3086)

Add entry point for sentry_sdk.integrations.opentelemetry.SentryPropagator.
This makes possible to configure opentelemetry using environment variables
and add SentryPropagator to existing ones instead of replace them.

Closes getsentry#3085

Co-authored-by: Neel Shah <neel.shah@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add entry point for opentelemetry propagator
4 participants