Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

captureMessage on Android using attachStacktrace=true does not send the stacktrace #2131

Closed
marandaneto opened this issue Mar 10, 2022 · 2 comments · Fixed by #2577
Closed

captureMessage on Android using attachStacktrace=true does not send the stacktrace #2131

marandaneto opened this issue Mar 10, 2022 · 2 comments · Fixed by #2577
Assignees
@krystofwoldrich
Labels
Blocked Hacktoberfest 🎃 Platform: React-Native Type: 🪲 Bug

Comments

@marandaneto
Copy link
Contributor

marandaneto commented Mar 10, 2022 •
edited
Loading

The JS SDK appends the stack trace to a top-level property instead of the threads interface.
It works on iOS because the event is sent as it is.
It fails on Android because of the round trip serialization, since this property does not exist on Android, it's lost.

  • Android V6 keeps the unknown fields, which would solve the problem (Still alpha tho).
  • The JS SDK could adapt it to use the threads interface (Gonna be done on V7, See the issue).
  • The RN SDK could process the event and move the top-level property within the threads interface.

The 3rd option right now seems faster/easier.
@bruno-garcia bruno-garcia moved this to Needs Discussion in Mobile & Cross Platform SDK Mar 10, 2022
@marandaneto marandaneto moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Mar 18, 2022
@marandaneto marandaneto moved this from Backlog to Blocked in Mobile & Cross Platform SDK Mar 18, 2022
@marandaneto
Copy link
Contributor Author

We've decided to go either with upgrading the Android SDK to v6 or JS SDK to v7, the one that comes first.

@marandaneto marandaneto moved this from Blocked to Backlog in Mobile & Cross Platform SDK Jun 30, 2022
@marandaneto marandaneto mentioned this issue Sep 8, 2022
Closed
@marandaneto marandaneto mentioned this issue Oct 4, 2022
Closed
@marandaneto marandaneto moved this from Backlog to Blocked in Mobile & Cross Platform SDK Oct 4, 2022
@marandaneto
Copy link
Contributor Author

Blocked by getsentry/sentry-javascript#5879

This was referenced Oct 25, 2022
Closed
Merged
@krystofwoldrich krystofwoldrich moved this from Blocked to In Progress in Mobile & Cross Platform SDK Oct 27, 2022
@krystofwoldrich krystofwoldrich self-assigned this Oct 27, 2022
@krystofwoldrich krystofwoldrich moved this from In Progress to Needs Review in Mobile & Cross Platform SDK Oct 27, 2022
Repository owner moved this from Needs Review to Done in Mobile & Cross Platform SDK Oct 31, 2022
This was referenced Feb 23, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krystofwoldrich krystofwoldrich

Labels
Blocked Hacktoberfest 🎃 Platform: React-Native Type: 🪲 Bug
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(event): Message event contains stacktrace if attachStacktrace o… getsentry/sentry-react-native
2 participants
@marandaneto @krystofwoldrich