You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Yikes. I see this was in the old code and you are just refactoring, but we really shouldn't completely lose this task. It should be saved somewhere. We should also register it for cancellation so it can be shut down gracefully. I'm OK if this is done in a future PR, but wanted to point it out.
_options.DiagnosticLogger?.Log(SentryLevel.Warning,"Sentry.Xamarin.Forms timeout for tracking Application.Current. Navigation tracking is going to be disabled");
return;
}
foreach(varhookin_listeners)
{
hook.Invoke(application);
}
});
The text was updated successfully, but these errors were encountered:
Task.Run() should have the value assigned somewhere and the result/exception inspected, or at least a whole try/catch in the body handling any error (we should do this anyway). Also we could go with ContinuesWith(...)
To not lose the comment from Matt
#108 (review)
On
sentry-xamarin/Src/Sentry.Xamarin.Forms/Internals/FormsApplicationListener.cs
Lines 30 to 45 in 6c15473
The text was updated successfully, but these errors were encountered: