Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-hydration-errors inbound filter doesn't catch all errors #45363

Closed
jeengbe opened this issue Mar 3, 2023 · 5 comments
Closed

react-hydration-errors inbound filter doesn't catch all errors #45363

jeengbe opened this issue Mar 3, 2023 · 5 comments

Comments

@jeengbe
Copy link

jeengbe commented Mar 3, 2023

Environment

SaaS (https://sentry.io/)

Version

No response

Link

https://prisjakt-ab.sentry.io/issues/3933815010/?project=1228836

DSN

No response

Steps to Reproduce

n/a

Expected Result

With #45188, React hydration errors should be filtered out directly. This is sadly not the case.

Actual Result

After removing client-side hydration error filtering, this is what happened:

image

@getsantry
Copy link
Contributor

getsantry bot commented Mar 3, 2023

Assigning to @getsentry/support for routing, due by Friday, March 3rd at 5:00 pm (sfo). ⏲️

@priscilawebdev
Copy link
Member

We have shipped a small fix a few hours ago. Do you think you can test again and see if it is filtering out? 🙏

@priscilawebdev
Copy link
Member

but yes you are right...we are only filtering the most common cases as listed here

# 418 - Hydration failed because the initial UI does not match what was rendered on the server.
# 419 - The server could not finish this Suspense boundary, likely due to an error during server rendering. Switched to client rendering.
# 422 - There was an error while hydrating this Suspense boundary. Switched to client rendering.
# 423 - There was an error while hydrating. Because the error happened outside of a Suspense boundary, the entire root will switch to client rendering.
# 425 - Text content does not match server-rendered HTML.

@getsantry
Copy link
Contributor

getsantry bot commented Mar 3, 2023

Routing to @getsentry/team-web-sdk-frontend for triage, due by Tuesday, March 7th at 9:14 am (sfo). ⏲️

@jeengbe
Copy link
Author

jeengbe commented Mar 3, 2023

@priscilawebdev

We have shipped a small fix a few hours ago. Do you think you can test again and see if it is filtering out? 🙏

It's fixed now, thanks! 🙏🏻

@jeengbe jeengbe closed this as completed Mar 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants