Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support upload of GZIPped artifacts through the API #4566

Closed
urbany opened this issue Nov 18, 2016 · 21 comments · Fixed by #4677
Closed

Support upload of GZIPped artifacts through the API #4566

urbany opened this issue Nov 18, 2016 · 21 comments · Fixed by #4677
Assignees

Comments

@urbany
Copy link

urbany commented Nov 18, 2016

Hi, would it be possible to upload GZIPped artifacts through the sentry API when the upload is done with the Header Content-Encoding: gzip?

Basically if that header is present during upload Sentry would unzip the received artifact after the upload is complete (ex: a sourcemap) and keep the same name.

@mattrobenolt
Copy link
Contributor

You can already do this with the header parameter specified here: https://docs.sentry.io/api/releases/post-release-files/

Note that it's a parameter on the request, NOT an actual header on the request, if that makes sense.

@urbany
Copy link
Author

urbany commented Nov 18, 2016

@mattrobenolt thank you for the quick reply!
I tried this but without luck:

var formData = {
  name: urljoin(this.sentrySettings.publicUrl, filePath),
  file: fs.createReadStream(fileName),
  header: 'Content-Encoding:gzip',
};

Still seeing this:
screen shot 2016-11-18 at 15 47 55

@mattrobenolt
Copy link
Contributor

Is this on sentry.io?

@urbany
Copy link
Author

urbany commented Nov 18, 2016

yes

@mattrobenolt
Copy link
Contributor

Mind emailing into support@ so I can take a look? :)

@urbany
Copy link
Author

urbany commented Nov 18, 2016

Sure thing mate, will email right now, thanks!

@kmiyashiro
Copy link

Any updates on this?

@mattrobenolt
Copy link
Contributor

@kmiyashiro I have not fixed this yet, but definitely plan on doing so soon. Possibly this week.

@mattrobenolt mattrobenolt reopened this Dec 14, 2016
@mattrobenolt
Copy link
Contributor

Reopening since this was a thing I thought worked, which doesn't. Bad mistake considering I wrote the code too. :(

@kmiyashiro
Copy link

🎉 🎉 🎉

@mattrobenolt mattrobenolt reopened this Dec 15, 2016
@mattrobenolt
Copy link
Contributor

welp, something here wasn't great. Will need to try again.

@duizendnegen
Copy link

Could I ping you for an update?

@urbany
Copy link
Author

urbany commented Jun 26, 2017

Hi @mattrobenolt sorry for bothering you, but do you know if this is still getting fixed?

@LevelbossMike
Copy link

@mattrobenolt Does this mean it's impossible to upload gzipped files? This is slowing down deployment considerably. Can we help in any way getting this fixed?

@duizendnegen
Copy link

Any update @mattrobenolt?

@duizendnegen
Copy link

Could I ask again for an update on this @mattrobenolt?

@Saravanan90
Copy link

Looking forward for gzip support in Sentry, it will make things simple

@xcambar
Copy link

xcambar commented Apr 10, 2018

To the many people waiting for this issue to move forward: did you find a service (and if so, which?) that you'd recommend for features/support/community?

My email is open if not comfortable to reply here.

@TheDoofWarrior
Copy link

Has anyone found a workaround for this?

@BYK BYK assigned mattrobenolt and BYK and unassigned mattrobenolt Jul 10, 2019
@BYK
Copy link
Member

BYK commented Jul 10, 2019

I'm told that #9238 should have fixed this. Will verify and close if that's the case and investigate more otherwise.

@BYK
Copy link
Member

BYK commented Oct 22, 2020

Closing this issue due to staleness. Feel free to comment here if you think we should still work on this.

@BYK BYK closed this as completed Oct 22, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants