Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project: Metrics Normalization #80

Closed
11 tasks done
cleptric opened this issue Apr 4, 2024 · 1 comment
Closed
11 tasks done

Project: Metrics Normalization #80

cleptric opened this issue Apr 4, 2024 · 1 comment

Comments

@cleptric
Copy link
Member

cleptric commented Apr 4, 2024

Description

SDKs that support metrics today, already perform normalization on certain parts of a metric.
We updated these rulesets and extended the allowed characters for tag values.
The specification can be found on develop, https://develop.sentry.dev/sdk/metrics/#normalization.

A quick TL;DR: How to Implement

Update or add the replacement regexes for metric units, metric keys and tag keys and check if the correct replacement characters are applied.
Remove the prior replacement regex and implement the replacement map for tag values.

Get inspired by the PHP SDK PR or the Relay PR.

Why should we be doing this?

We want to future-proof our metrics pipeline by allowing us to set certain exceptions about the payloads we receive from the SDKs and be compatible with our new Snuba MQL query dialect.

Why now?

This is a joint effort between SDKs, Ingest and Telemetry. Given the importance of the Metrics product at Sentry and the small scope of this task, we'll prioritize this.
Implementation should be finished by Friday, April 12th.

Stakeholder(s)

@jan-auer @cleptric

Team(s)

Web Backend, Web Frontend, Mobile

Implementation Status

Web Backend SDKs

  1. Enhancement
    sentrivana
  2. cleptric
  3. enhancement metrics
    sl0thentr0py
  4. Product: Metrics
    jamescrosswell

Web Frontend SDKs

  1. Feature: Metrics
    timfish

Mobile SDKs

  1. Platform: Android Platform: Java enhancement
    markushi
  2. Platform: Dart enhancement
  3. Platform: Cocoa Platform: iOS Type: Enhancement
    philipphofmann
@krystofwoldrich
Copy link
Member

@stephanie-anderson stephanie-anderson added this to the Metrics milestone Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants