You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now there are a few explicit commands (exec-env, exec-file, publish, keyservice, groups, updatekeys, help), and several implicit ones (--encrypt, --decrypt, --rotate, --set, edit), some pseudo-commands which only work with other commands (--extract with --decrypt, --rm-* and --add-* with --rotate).
This is pretty confusing, both from the sops --help output and also from the code (it is not trivial to figure out which of the flags are commands), and we have a long list of top-level flags which are only used in some of the commands, or even just one (like --extract, --rm-*, --add-*).
I think it would be better long term to migrate all "flag commands" (--encrypt, --decrypt, --rotate, --set, and the fallback 'edit') to proper subcommands. I would do this in three steps:
Add proper commands (additionally to the existing flag commands).
Eventually deprecate the use of global flags outside of the (flag) commands where they are really needed.
Eventually deprecate the flag commands themselves.
Eventually remove the flag commands, and remove global flags for command-specific options.
1. should be done soon, 2. better sooner than later (this also makes the situation less confusing by telling users that the option they provided isn't actually used by the command they try to use), and 3. should only happen in a longer time (some years from now), and 4. even further in the future (say, at least 4-5 years?).
What do you think?
The text was updated successfully, but these errors were encountered:
felixfontein
changed the title
Make encrypt and decrypt proper commands
Make encrypt, decrypt, rotate, set, and edit proper commands
Oct 29, 2023
Right now there are a few explicit commands (
exec-env
,exec-file
,publish
,keyservice
,groups
,updatekeys
,help
), and several implicit ones (--encrypt
,--decrypt
,--rotate
,--set
, edit), some pseudo-commands which only work with other commands (--extract
with--decrypt
,--rm-*
and--add-*
with--rotate
).This is pretty confusing, both from the
sops --help
output and also from the code (it is not trivial to figure out which of the flags are commands), and we have a long list of top-level flags which are only used in some of the commands, or even just one (like--extract
,--rm-*
,--add-*
).I think it would be better long term to migrate all "flag commands" (
--encrypt
,--decrypt
,--rotate
,--set
, and the fallback 'edit') to proper subcommands. I would do this in three steps:1. should be done soon, 2. better sooner than later (this also makes the situation less confusing by telling users that the option they provided isn't actually used by the command they try to use), and 3. should only happen in a longer time (some years from now), and 4. even further in the future (say, at least 4-5 years?).
What do you think?
The text was updated successfully, but these errors were encountered: