Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store AWS KMS Key Id instead of Alias in encrypted files #476

Open
michael-k opened this issue Jun 11, 2019 · 1 comment
Open

Store AWS KMS Key Id instead of Alias in encrypted files #476

michael-k opened this issue Jun 11, 2019 · 1 comment

Comments

@michael-k
Copy link
Contributor

Support for AWS KMS Aliases was requested in #381 and implemented in #415. We tried to switch to aliases in the creation_rules, but noticed that the alias' ARN is being stored in encrypted files instead of the key's ARN.

If an alias is deleted or reassigned to another key, it's impossible to find out which KMS Key was actually used.

The EncryptOutput returned by KMS.Encrypt contains the Key Id¹ that was used during encryption and that is what should be stored in the encrypted file.

¹ I'm not sure if this is just the Id or the ARN. See https://docs.aws.amazon.com/kms/latest/APIReference/API_Encrypt.html#API_Encrypt_ResponseSyntax (including the examples)

@gdhameeja
Copy link

I'd like to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants