-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redo configuration logic #87
Redo configuration logic #87
Conversation
If you add the /.. traversal before readlink instead of after it will resolve it into the direct path
The quotes are either not doing anything: This: "some string ""$some_var"" some string" Is the same as: "some string $some_var some string" Or are actually unquoting the variable: This: "some string "$some_var" some string" Means $some_var is unquoted and will be subject to word splitting and glob expansion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff!
Some minor tweaks needed which are mostly resolved by this PR: https://github.com/mayankchhabra/umbrel/pull/7
I really love how this gives us a single source of truth for the configuration and we can use to rebuild the actual config files at any point in time.
One other suggestion, after running the configure script in an active git repo, you get the following:
We should add these files to It would probably be best to add the entire dirs to .gitignore and then just un-ignore the |
I also really love how |
Awesome! Thanks for the review and fixes, man. Also:
Great suggestion! Updated. Looking good to merge :) |
The PR rewrites the configuration logic to achieve the following:
Use templates to generate configuration files for
bitcoind
,lnd
andtor
(h/t @lukechilds for the awesome idea).Store RPC + Tor credentials in
$UMBREL_ROOT/.env
instead ofsecrets/
directory, allowing us to directly refer them in the Docker services as environment variables vs. having them hardcoded/patched.Reconfigure the installation over and over, even if it fails.
OTA updates will now configure a new release as a fresh install with new configuration files and the existing (persistent) data.
OTA updates will also pick-up the network (mainnet, testnet or regtest) from the existing
.env
and configure the new release for it.Commit
rpcauth.py
toscripts/
so the installation is more deterministic.Generate a different password for Tor instead of using the RPC password.