Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copying images of different formats on Metal #2026

Open
kvark opened this issue May 14, 2018 · 1 comment
Open

Fix copying images of different formats on Metal #2026

kvark opened this issue May 14, 2018 · 1 comment

Comments

@kvark
Copy link
Member

kvark commented May 14, 2018

Relevant test is "dEQP-VK.api.copy_and_blit.core.image_to_image.simple_tests.whole_image_diff_format"

Metal copying requires pixel formats to match exactly. Vulkan only requires the total bit sizes to match. Whenever we detect that the formats are actually different, we reinterpret the source image with the destination format.

Unfortunately, the test still fails. Trying to modify Warden test to check this gives me interesting results:

  • casting R32Uint to Rgba8Uint ends up filling only R component (d'oh, not expected)
  • running via XCode debugger actually crashes in commit()...
@kvark
Copy link
Member Author

kvark commented May 18, 2018

I've spent quite a bit more time looking at this (than I'd hope to), and I consider this to be a candidate for Apple Metal upstream bug. I filed a private bug report, but we'll really need a simple repro case (written in ObjC/Swift) for them to investigate.

@kvark kvark added client: CTS Has associated Vulkan CTS tests that fail or crash and removed client: request feature request from a known client labels May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant