Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocessor for glsl-new #132

Closed
lachlansneff opened this issue Aug 17, 2020 · 4 comments
Closed

Preprocessor for glsl-new #132

lachlansneff opened this issue Aug 17, 2020 · 4 comments
Labels
area: front-end Input formats for conversion kind: feature New feature or request lang: GLSL OpenGL Shading Language

Comments

@lachlansneff
Copy link
Contributor

I threw together a quick, partial implementation of the glsl preprocessor (notably doesn't support #if or #elif because I didn't want to implement constant expression evaluation) for bevy (here) because the glsl-new frontend doesn't have one. I'm happy to donate this to naga if it's wanted as a starting point.

@pjoe
Copy link
Collaborator

pjoe commented Oct 14, 2020

Initial code in #238

@fintelia
Copy link
Contributor

I think this is resolved?

@kvark
Copy link
Member

kvark commented Feb 16, 2021

@pjoe had concerns about the way we have it currently. I think the question still remains open, although it would be great to spell out all the details here.

@kvark
Copy link
Member

kvark commented Apr 16, 2021

#238 got merged

@kvark kvark closed this as completed Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: front-end Input formats for conversion kind: feature New feature or request lang: GLSL OpenGL Shading Language
Projects
None yet
Development

No branches or pull requests

4 participants