Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hlsl-out] Emit row_major qualifier on matrix uniform globals. #1846

Merged
merged 1 commit into from
Apr 17, 2022
Merged

[hlsl-out] Emit row_major qualifier on matrix uniform globals. #1846

merged 1 commit into from
Apr 17, 2022

Conversation

jimblandy
Copy link
Member

Fixes #1836.

@jimblandy
Copy link
Member Author

Looks like this fixes gfx-rs/wgpu#2584 on Windows:
https://github.com/jimblandy/wgpu/actions/runs/2179079016

@jimblandy jimblandy requested a review from cwfitzgerald April 17, 2022 06:48
@jimblandy jimblandy self-assigned this Apr 17, 2022
@jimblandy jimblandy added kind: bug Something isn't working area: back-end Outputs of shader conversion lang: HLSL High-Level Shading Language labels Apr 17, 2022
cwfitzgerald
cwfitzgerald approved these changes Apr 17, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks peachy

@jimblandy jimblandy merged commit ef387f7 into gfx-rs:master Apr 17, 2022
@jimblandy jimblandy deleted the hlsl-row-major-matrix-globals branch April 17, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees

@jimblandy jimblandy

Labels
area: back-end Outputs of shader conversion kind: bug Something isn't working lang: HLSL High-Level Shading Language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Naga drops HLSL row_major qualifier for global matrices
2 participants
@jimblandy @cwfitzgerald