Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpFunctionCall explicitly #148

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Add OpFunctionCall explicitly #148

merged 1 commit into from
Aug 12, 2020

Conversation

Jasper-Bekkers
Copy link
Collaborator

Most ops tagged with the Function class are models by our Function struct (eg. to create functions) however, OpFunctionCall also has the "Function" class, but should exist in the Builder.

@Jasper-Bekkers
Copy link
Collaborator Author

@kvark since me and @khyperia will be working on rspirv quite a bit going forward, do you think we can add her as a maintainer to this repo as well?

@kvark
Copy link
Member

kvark commented Aug 12, 2020

Do you maybe want it to be transferred under your org? I added @khyperia anyway.

@khyperia khyperia merged commit 86c4a70 into master Aug 12, 2020
@khyperia khyperia deleted the OpFunctionCall branch August 12, 2020 15:28
@Jasper-Bekkers Jasper-Bekkers mentioned this pull request Oct 7, 2020
Open
26 tasks
@Jasper-Bekkers Jasper-Bekkers mentioned this pull request Dec 10, 2020
Open
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khyperia khyperia khyperia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jasper-Bekkers @kvark @khyperia