Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use maxMemoryAllocationSize in Vulkan's memory allocator. #3141

Closed
i509VCB opened this issue Oct 27, 2022 · 0 comments · Fixed by #3567
Closed

Use maxMemoryAllocationSize in Vulkan's memory allocator. #3141

i509VCB opened this issue Oct 27, 2022 · 0 comments · Fixed by #3567
Labels
api: vulkan Issues with Vulkan help required We need community help to make this happen. type: enhancement New feature or request

Comments

@i509VCB
Copy link
Contributor

i509VCB commented Oct 27, 2022

Description
wgpu-hal's internal memory allocator for Vulkan should respect the maxMemoryAllocationSize limit introduced in the VK_KHR_maintanence3 extension. This extension is part of the core specification in Vulkan 1.1.

This probably also needs to be added as a parameter into Adapter::device_from_raw as well.

Right now the maximum size is a stub value, which very well may not be u64::MAX everywhere:

max_memory_allocation_size: u64::max_value(), // TODO

@cwfitzgerald cwfitzgerald added type: enhancement New feature or request api: vulkan Issues with Vulkan help required We need community help to make this happen. labels Oct 28, 2022
@teoxoy teoxoy added this to the WebGPU Specification V1 milestone Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vulkan Issues with Vulkan help required We need community help to make this happen. type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants