Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renderpass Compatibility Errors Are Missing Context #3536

Closed
cwfitzgerald opened this issue Feb 28, 2023 · 0 comments · Fixed by #3549
Closed

Renderpass Compatibility Errors Are Missing Context #3536

cwfitzgerald opened this issue Feb 28, 2023 · 0 comments · Fixed by #3549
Labels
area: api Issues related to API surface type: enhancement New feature or request

Comments

@cwfitzgerald
Copy link
Member

https://github.com/gfx-rs/wgpu/blob/master/wgpu-core/src/device/mod.rs#L82-L91 are examples of errors that are missing quite a bit of context to the user.

For example:

IncompatibleSampleCount should go

from: Incompatible sample count: the renderpass expected 1 but was given 4

to: Incompatible sample count: the renderpass uses textures with 1 sample but was given a pipeline outputting 4 samples
@cwfitzgerald cwfitzgerald added type: enhancement New feature or request area: api Issues related to API surface labels Feb 28, 2023
@cwfitzgerald cwfitzgerald mentioned this issue Mar 1, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: api Issues related to API surface type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve RenderPass related errors cwfitzgerald/wgpu
1 participant
@cwfitzgerald