-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relicense under dual MIT/Apache-2.0 #392
Comments
Uh, I guess I missed this email for a while. Anyway, if you're going to do this re-license thing anyway, I would strongly suggest |
Really?.... 😢 |
It is the license used by zlib, libpng, and SDL2, so your game dev shop probably already is familiar with it. Google allows Zlib, it took less than an hour to get it approved and added to their accepted license lib. Zlib is very clearly superior to MIT from a perspective of keeping license text bloat under control in our ecosystem as we try to start developing and shipping binaries to people in the coming years. |
Or MIT / Apache / Zlib tri-license would be fine. |
I'm assuming by "keeping license text bloat under control" you are referring to this part of the license?
|
Yes, a zlib binary does not have to carry the license text for zlib dependencies. Given the average dependency count of rust stuff (50-150, sometimes as high as 400), this is actually burdensome. |
@Lokathor do you know how to summon this bot that would invite people to comment? We want it on both wgpu and wgpu-rs repos. |
I don't know of any special github bots. |
@cmr how do we get a bot to generate an issue like gfx-rs/gfx#847 ? |
@kvark I found this repo which may be the source of the script https://github.com/emberian/relicense-assistant |
I adapted the script a bit to generate the text for an issue: issue.txt #!/usr/bin/env python3
from github import Github
import os
g = Github(os.getenv("GH_API_TOKEN"))
tpl = open("issue-template.txt").read()
issue = open("issue.txt", "w")
repo = "gfx-rs/wgpu"
project_name = "wgpu"
try:
r = g.get_repo(repo)
contribs = "\n".join(sorted(map(lambda u: " - [ ] @{}".format(u.login), r.get_contributors())))
issue_body = tpl.replace("{{project_name}}", project_name) + "\n" + contribs
issue.write("Relicense under dual MIT/Apache-2.0\n\n")
issue.write(issue_body)
except Exception as e:
print("Some exception in {}".format(repo))
print(e) |
@Imberflur could you... run it? |
I linked the generated text, do you want me to create an issue? I figured it could be created manually and might need some tweaking for flavor. |
Thank you! |
Strange that a part of the list is in bold |
I vaguely remember that's because GitHub has a maximum number of people you can ping in a single message, everyone not in bold didn't get pinged so are unlikely to notice the post. |
See gfx-rs/gfx#847
cc @Lokathor
The text was updated successfully, but these errors were encountered: