Error messages are garbled and truncated in firefox console log

[glalonde]

Not sure if this is a naga issue or something with my console_log setup, but it looks like it is naga. The truncation is the frustrating part.

[jimblandy]

I think part of the problem is here: https://github.com/gfx-rs/wgpu/blob/master/wgpu-core/src/pipeline.rs#L84

The implementation of std::fmt::Display for ShaderError is using ANSI color escape codes by default. The Firefox console isn't prepared for that. wgpu-core should somehow let its user indicate whether color is appropriate, and Firefox should decline.

The truncation is probably an arbitrary limit imposed somewhere to prevent denial-of-service attacks. Removing the escape codes will reduce the length of the message, but now that Naga produces more detailed error messages in general (with the span feature), we may need to simply raise the limit to accommodate the new typical error message length.

[kvark]

What firefox version is this? At least truncation is something I fixed a few weeks ago.

[glalonde]

I think it was a nightly build from 1/03/22? updated it to get around the error, so I'm not sure anymore.

[kvark]

hmm, the fix I'm thinking was done much earlier - https://hg.mozilla.org/mozilla-central/rev/469124ce89e9

[teoxoy]

#3591 fixed the ANSI color escape codes being embedded in the messages.

Let's track further improvements in #4494.