Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask Off Haswell Devices on Vulkan #4715

Closed
cwfitzgerald opened this issue Nov 17, 2023 · 5 comments · Fixed by #4718
Closed

Mask Off Haswell Devices on Vulkan #4715

cwfitzgerald opened this issue Nov 17, 2023 · 5 comments · Fixed by #4718
Labels
api: vulkan Issues with Vulkan type: enhancement New feature or request

Comments

@cwfitzgerald
Copy link
Member

Similarly to #4709, we should remove all vulkan instances of haswell gpus. These only show up on mesa https://gitlab.freedesktop.org/mesa/mesa/-/blob/242c7a651308f43d5f6f2590717fd72f44eba3ca/src/intel/vulkan/anv_device.c#L769-775. They aren't compliant and will never be compliant. I can't find the post now, but jekstrand said that trying to support vulkan on haswell was a mistake as it gave people the impression it was possible.

Maybe we have an instance flag that disables masking if people really care.

cc @teoxoy

@cwfitzgerald cwfitzgerald added type: enhancement New feature or request api: vulkan Issues with Vulkan labels Nov 17, 2023
@teoxoy
Copy link
Member

teoxoy commented Nov 17, 2023

I have a broader patch that should take care of this, I was looking through our issues to see which ones the PR would take care of.

Will put it up soon.

@melody-rs
Copy link

I'm curious why Haswell isn't compliant?

@cwfitzgerald
Copy link
Member Author

cwfitzgerald commented Nov 17, 2023

Basically the gen7 hardware doesn't have the features needed to meet vulkan 1.0. On the proprietary drivers, vulkan support only shows up in skylake (gen8)

@melody-rs
Copy link

Oh, that's annoying. I've been doing most of my development on a haswell laptop :(

@cwfitzgerald
Copy link
Member Author

Wgpu will still work for you, it will just be via GLES 3.2 instead of Vulkan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vulkan Issues with Vulkan type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants