Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converge dual-source blending with the WebGPU standard #6402

Open
ErichDonGubler opened this issue Oct 11, 2024 · 4 comments
Open

Converge dual-source blending with the WebGPU standard #6402

ErichDonGubler opened this issue Oct 11, 2024 · 4 comments
Labels
api: webgpu Issues with direct interface with WebGPU area: api Issues related to API surface area: ecosystem Help the connected projects grow and prosper area: validation Issues related to validation, diagnostics, and error handling lang: WGSL WebGPU Shading Language naga Shader Translator type: enhancement New feature or request

Comments

@ErichDonGubler
Copy link
Member

ErichDonGubler commented Oct 11, 2024 •
edited
Loading

https://www.w3.org/TR/webgpu/#dom-gpufeaturename-dual-source-blending

Firefox downstream tracking: bug 1924328
@ErichDonGubler ErichDonGubler added area: validation Issues related to validation, diagnostics, and error handling naga Shader Translator type: enhancement New feature or request lang: WGSL WebGPU Shading Language area: api Issues related to API surface area: ecosystem Help the connected projects grow and prosper api: webgpu Issues with direct interface with WebGPU labels Oct 12, 2024
@ErichDonGubler ErichDonGubler changed the title WGSL: support enable dual_source_blending; Support dual-source blending Oct 12, 2024
@teoxoy
Copy link
Member

teoxoy commented Oct 14, 2024

We already support dual-source blending (#1804) but I think our validation is not 1:1 with the spec.

@ErichDonGubler ErichDonGubler changed the title Support dual-source blending Converge dual-source blending with the WebGPU standard Oct 16, 2024
@ErichDonGubler
Copy link
Member Author

@teoxoy: Ah, yes. I've renamed the issue to note that the scope is to converge with the spec.

@ErichDonGubler ErichDonGubler mentioned this issue Oct 18, 2024
Merged
7 tasks
@jimblandy
Copy link
Member

So the work here is:

  • Figure out what the spec says
  • Figure out what we're doing wrong, exactly

Teo suspects that our validation is too strict.

We are using the wrong names for things.

We don't have the enable implemented in the WGSL front end.

There are probably API bits too.

@jimblandy
Copy link
Member

Also, we're probably exposing this even when the feature isn't enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: webgpu Issues with direct interface with WebGPU area: api Issues related to API surface area: ecosystem Help the connected projects grow and prosper area: validation Issues related to validation, diagnostics, and error handling lang: WGSL WebGPU Shading Language naga Shader Translator type: enhancement New feature or request
Projects
WebGPU for Firefox
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ErichDonGubler @jimblandy @teoxoy