-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shader I64 and U64 support #5154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Howdy! wgpu test fairy here: could you add execution tests for this in wgpu. We need at least one test, but there could be other things:
- struct layout should be tested in struct_layout.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This needs a rebase or another merge of trunk into it. |
Connections
Part of an incoming series of PRs needed by #5123
Others in this series: #5155
Addresses #4424
Ultimately for bevy meshlets pipeline bevyengine/bevy#10164
Description
Shaders currently do not support 64 bit integer types. Add support for these gated by a feature flag when the capability is present.
Testing
A snapshot test called i64.wgsl has been added to test parsing, type casting, and other basic operations.
Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.