Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hal] Document Queue::submit ordering guarantees a bit. #5563

Merged
merged 1 commit into from
Apr 28, 2024
Merged

[hal] Document Queue::submit ordering guarantees a bit. #5563

merged 1 commit into from
Apr 28, 2024

Conversation

jimblandy
Copy link
Member

No description provided.

@jimblandy jimblandy requested a review from a team as a code owner April 19, 2024 03:52
@jimblandy jimblandy marked this pull request as draft April 19, 2024 03:53
@jimblandy
Copy link
Member Author

Hmm... I think this could be phrased better.

JMS55
JMS55 reviewed Apr 19, 2024
View reviewed changes
wgpu-hal/src/lib.rs Outdated Show resolved Hide resolved
@jimblandy jimblandy force-pushed the hal-doc-queue-submit-ordering branch from e8e71ef to 2e61813 Compare April 20, 2024 00:33
@jimblandy jimblandy force-pushed the hal-doc-queue-submit-ordering branch 2 times, most recently from cba7afd to fab5312 Compare April 27, 2024 19:14
@jimblandy jimblandy marked this pull request as ready for review April 27, 2024 19:15
@jimblandy
Copy link
Member Author

This will conflict with the other hal doc PRs, but it's fine to review.

@jimblandy jimblandy force-pushed the hal-doc-queue-submit-ordering branch from fab5312 to 8441edb Compare April 27, 2024 19:27
Wumpf
Wumpf approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tough one. I had to spend quite a bit of time convince myself of this bit all complete execution before any of the second submission's commands begin, but from the looks of it we really do enforce that strictly.

@jimblandy
Copy link
Member Author

tough one. I had to spend quite a bit of time convince myself of this bit all complete execution before any of the second submission's commands begin, but from the looks of it we really do enforce that strictly.

Thank you for the close reading! I was unsure too, but I think we couldn't function without this requirement, because waiting for fence values only works if things actually complete in increasing fence value order. But see also #5559.

@jimblandy jimblandy merged commit 4af2e7b into gfx-rs:trunk Apr 28, 2024
25 checks passed
@jimblandy jimblandy deleted the hal-doc-queue-submit-ordering branch April 28, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JMS55 JMS55 JMS55 left review comments

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimblandy @Wumpf @JMS55