Cast ptr to Device not Surface #5640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arc has device stored inside not surface. fixes gfx-rs#5637
cwfitzgerald
added
the
PR: needs back-porting
ErichDonGubler
approved these changes
Apr 30, 2024
| @@ -34,7 +34,7 @@ impl AnyDevice { | |||
| unsafe fn drop_glue<A: HalApi>(ptr: *mut ()) { | |||
| // Drop the arc this instance is holding. | |||
| unsafe { | |||
| _ = Arc::from_raw(ptr.cast::<A::Surface>()); | |||
| _ = Arc::from_raw(ptr.cast::<A::Device>()); | |||
vorporeal
pushed a commit
to warpdotdev/wgpu
that referenced
this pull request
May 9, 2024
Wumpf
pushed a commit
to Wumpf/wgpu
that referenced
this pull request
May 18, 2024
ErichDonGubler
pushed a commit
that referenced
this pull request
May 18, 2024
|
this fix here has a little whoopsie in there, fixed here: (noticed only now after merging that these are related) |
6 tasks
|
Unsafe code is hard 😔. |
morr0ne
pushed a commit
to verdiwm/wgpu
that referenced
this pull request
Jul 28, 2024
cwfitzgerald
removed
the
PR: needs back-porting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arc has device stored inside not surface.
fixes #5637
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.