Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[d3d12] Drop resource before free suballocation #5943

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

xiaopengli89
Copy link
Contributor

Connections
Close #5940

Description
Dropping resource before free suballocation can resolve the problem, which maybe cause by internal mechanism of gpu-allocator.

Testing
image

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@xiaopengli89 xiaopengli89 requested a review from a team as a code owner July 11, 2024 10:18
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for the fix!

@teoxoy teoxoy changed the title Drop resource before free suballoction [d3d12] Drop resource before free suballocation Jul 11, 2024
@teoxoy teoxoy merged commit 349f182 into gfx-rs:trunk Jul 11, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buffer leaks
2 participants