server : fix smart selection of available slot #10120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasha0552
changed the title
ngxson
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Looking very good, thanks for implementing this.
@ggerganov Could you have a quick look too? Btw with this change, does it make sense to increase the default value of n_cache_reuse?
Edit: hah sorry I didn't saw your comment above
Probably yes. Though I am hoping to see more feedback from this option to make sure it does not have some side-effects, as it is a bit fringe science at this point. So far I think it works fine based on my code-completion experiments, but I could be testing a very narrow case. |
|
Thanks for dealing with this @sasha0552 |
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
* Fix smart selection of available slot * minor fix * replace vectors of tokens with shorthands
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
* Fix smart selection of available slot * minor fix * replace vectors of tokens with shorthands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes smart selection of available slot that was broken in #10023, replaces algorithm with Longest Common Subsequence (due to #9866), cleans up unnecessary code.
cc: @chrisstankevitz, @ngxson