Add ROCM aliases for CUDA pool stuff #3918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KerfuffleV2
added
bug
ggerganov
approved these changes
Nov 2, 2023
|
Though it compiles with this, something still seems wrong. I'm not sure if it's ROCM specific. Offloading the last non-repeating layer (KV) produces all NaNs. I.E. Orca 3B model with 26 actual layers is okay offloading up to 28, but 29 doesn't work. Mistral with 32 real layers is okay is okay at 34 but 35 doesn't work. edit: Actually it seem like it's okay when compiling without |
Could be related to #2268 (comment) |
ggerganov
pushed a commit
that referenced
this pull request
Nov 5, 2023
olexiyb
pushed a commit
to Sanctum-AI/llama.cpp
that referenced
this pull request
Nov 23, 2023
olexiyb
pushed a commit
to Sanctum-AI/llama.cpp
that referenced
this pull request
Nov 23, 2023
* Revert "cuda : add ROCM aliases for CUDA pool stuff (ggerganov#3918)" This reverts commit 629f917. * Revert "cuda : use CUDA memory pool with async memory allocation/deallocation when available (ggerganov#3903)" This reverts commit d606905. ggml-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, guess what? ROCM is broken again! The good news is it seems like an easy fix. (BTW, sorry GG, I didn't see your other request for review in time.)