From 8b8a38068d63bbe8e6c70a2ffc0aca5ce9701db4 Mon Sep 17 00:00:00 2001 From: brian khuu Date: Mon, 27 May 2024 20:46:49 +1000 Subject: [PATCH 1/2] github: add refactor issue template [no ci] --- .github/ISSUE_TEMPLATE/05-enhancement.yml | 2 +- .github/ISSUE_TEMPLATE/06-question.yml | 2 +- .github/ISSUE_TEMPLATE/07-refactor.yml | 63 +++++++++++++++++++++++ 3 files changed, 65 insertions(+), 2 deletions(-) create mode 100644 .github/ISSUE_TEMPLATE/07-refactor.yml diff --git a/.github/ISSUE_TEMPLATE/05-enhancement.yml b/.github/ISSUE_TEMPLATE/05-enhancement.yml index 7f516abb07609..58fca73183d41 100644 --- a/.github/ISSUE_TEMPLATE/05-enhancement.yml +++ b/.github/ISSUE_TEMPLATE/05-enhancement.yml @@ -1,4 +1,4 @@ -name: Enhancement template +name: Enhancement description: Used to request enhancements for llama.cpp title: "Feature Request: " labels: ["enhancement"] diff --git a/.github/ISSUE_TEMPLATE/06-question.yml b/.github/ISSUE_TEMPLATE/06-question.yml index 23ad2f4199081..9d3ff4972383e 100644 --- a/.github/ISSUE_TEMPLATE/06-question.yml +++ b/.github/ISSUE_TEMPLATE/06-question.yml @@ -1,4 +1,4 @@ -name: Question template +name: Question description: Used to ask questions about llama.cpp title: "Question: " labels: ["question"] diff --git a/.github/ISSUE_TEMPLATE/07-refactor.yml b/.github/ISSUE_TEMPLATE/07-refactor.yml new file mode 100644 index 0000000000000..c32de4fb8fe5d --- /dev/null +++ b/.github/ISSUE_TEMPLATE/07-refactor.yml @@ -0,0 +1,63 @@ +name: Refactor (Maintainers) +description: Used to track refactoring opportunities +title: "Refactor: " +labels: ["refactor"] +body: + - type: markdown + attributes: + value: | + Don't forget to [check for existing refactor issue tickets](https://github.com/ggerganov/llama.cpp/issues?q=is%3Aopen+is%3Aissue+label%3Arefactoring) in case it's already covered. + Also you may want to check [Pull request refactor label as well](https://github.com/ggerganov/llama.cpp/pulls?q=is%3Aopen+is%3Apr+label%3Arefactoring) for duplicates too. + + - type: textarea + id: background-description + attributes: + label: Background Description + description: Please provide a detailed written description of the pain points you are trying to solve. + placeholder: Detailed description behind your motivation to request refactor + validations: + required: true + + - type: dropdown + id: grokkability + attributes: + label: Whats the current grokkability of the code in question + multiple: false + options: + - Easy + - Normal + - Hard + - "=.0" + + - type: dropdown + id: subsystems + attributes: + label: Which subsystems are you trying to refactor? + multiple: true + options: + - Kompute + - Apple Metal + - SYCL + - Nvidia GPU + - Vulkan + - Documentation + - Testing + - Build + - Examples + - Devops + - Python + - Script + - Android + - Server + - GGML + - Nix + - Embedding + + - type: textarea + id: possible-approaches + attributes: + label: Possible Refactor Approaches + description: If you have some idea of possible approaches to solve this problem. You may want to make it a todo list. + placeholder: Your idea of possible refactoring opportunity/approaches + validations: + required: false From dd53eb9380f4e0f24b002da0cda99233156ee60d Mon Sep 17 00:00:00 2001 From: Brian Date: Tue, 28 May 2024 20:26:08 +1000 Subject: [PATCH 2/2] Update 07-refactor.yml --- .github/ISSUE_TEMPLATE/07-refactor.yml | 35 -------------------------- 1 file changed, 35 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/07-refactor.yml b/.github/ISSUE_TEMPLATE/07-refactor.yml index c32de4fb8fe5d..3a68d3d5355d6 100644 --- a/.github/ISSUE_TEMPLATE/07-refactor.yml +++ b/.github/ISSUE_TEMPLATE/07-refactor.yml @@ -18,41 +18,6 @@ body: validations: required: true - - type: dropdown - id: grokkability - attributes: - label: Whats the current grokkability of the code in question - multiple: false - options: - - Easy - - Normal - - Hard - - "=.0" - - - type: dropdown - id: subsystems - attributes: - label: Which subsystems are you trying to refactor? - multiple: true - options: - - Kompute - - Apple Metal - - SYCL - - Nvidia GPU - - Vulkan - - Documentation - - Testing - - Build - - Examples - - Devops - - Python - - Script - - Android - - Server - - GGML - - Nix - - Embedding - - type: textarea id: possible-approaches attributes: