Feature: configure ip_version #359
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdesgarets
changed the title
|
Renamed to WIP
|
pdesgarets
changed the title
pdesgarets
force-pushed
the
feat/master/ip_version
branch
from
73d7bb2 to
101032b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #302
Adds
ip_versionoption (4 or 6) to define what IP should be used to ssh into the instance.Possible important change : it does not use the first network defined in the config at all costs, but checks every network from the config to see if one contains an IP of the desired version, even if it is not the first ranked.
Some "real use" tests should be performed before merging.Done, seems to work fineI added some unit tests, they might not cover every possible scenario.