From edd8db658c121ca8cc568fe3b5311cd8bda7b350 Mon Sep 17 00:00:00 2001 From: Edwin Njeru Date: Wed, 21 Mar 2018 11:10:59 +0300 Subject: [PATCH 1/3] added missing files --- pom.xml | 20 +++++++++++-------- .../keeper/book/{ => api}/Account.java | 2 +- .../book/{ => api}/AccountAttributes.java | 2 +- .../ghacupha/keeper/book/{ => api}/Entry.java | 6 +++--- .../book/{ => api}/EntryAttributes.java | 2 +- .../keeper/book/{ => api}/Transaction.java | 2 +- .../{internal => base}/AccountDetails.java | 6 +++--- .../book/{internal => base}/AccountImpl.java | 8 ++++---- .../{internal => base}/AccountingEntry.java | 8 ++++---- .../AccountingTransaction.java | 10 +++++----- .../AccoutingEntryDecorator.java | 8 ++++---- .../book/{internal => base}/EntryDetails.java | 6 +++--- .../TransactionalEntry.java | 10 +++++----- .../ghacupha/keeper/book/AccountTest.java | 12 +++++++---- .../keeper/book/EntryDetailsTest.java | 3 ++- .../AccountingTransactionTest.java | 10 +++++----- 16 files changed, 62 insertions(+), 53 deletions(-) rename src/main/java/io/github/ghacupha/keeper/book/{ => api}/Account.java (97%) rename src/main/java/io/github/ghacupha/keeper/book/{ => api}/AccountAttributes.java (98%) rename src/main/java/io/github/ghacupha/keeper/book/{ => api}/Entry.java (92%) rename src/main/java/io/github/ghacupha/keeper/book/{ => api}/EntryAttributes.java (98%) rename src/main/java/io/github/ghacupha/keeper/book/{ => api}/Transaction.java (98%) rename src/main/java/io/github/ghacupha/keeper/book/{internal => base}/AccountDetails.java (97%) rename src/main/java/io/github/ghacupha/keeper/book/{internal => base}/AccountImpl.java (96%) rename src/main/java/io/github/ghacupha/keeper/book/{internal => base}/AccountingEntry.java (96%) rename src/main/java/io/github/ghacupha/keeper/book/{internal => base}/AccountingTransaction.java (94%) rename src/main/java/io/github/ghacupha/keeper/book/{internal => base}/AccoutingEntryDecorator.java (85%) rename src/main/java/io/github/ghacupha/keeper/book/{internal => base}/EntryDetails.java (97%) rename src/main/java/io/github/ghacupha/keeper/book/{internal => base}/TransactionalEntry.java (84%) rename src/test/java/io/github/ghacupha/keeper/book/{internal => base}/AccountingTransactionTest.java (95%) diff --git a/pom.xml b/pom.xml index d64633d..5b45e2e 100644 --- a/pom.xml +++ b/pom.xml @@ -43,9 +43,11 @@ -Dapp.env=LOCAL -Dapp.domain=localhost -Dapp.port=9901 -Dapp.env=LOCAL -Dapp.domain=localhost -Dapp.port=9901 - 1.8 - 1.8 - 1.8 + 9 + 9 + 9 + javac9 + true 2.12.1 "documentation" ${project.build.directory}/coverage-reports/jacoco-it.exec @@ -399,7 +401,7 @@ - + org.sonatype.plugins nexus-staging-maven-plugin @@ -446,10 +448,12 @@ org.apache.maven.plugins maven-compiler-plugin - 3.7.0 + ${maven-compiler-plugin.version} - 1.8 - 1.8 + ${maven.compiler.source} + ${maven.compiler.target} + ${maven.compiler.fork} + ${maven.compiler.executable} diff --git a/src/main/java/io/github/ghacupha/keeper/book/Account.java b/src/main/java/io/github/ghacupha/keeper/book/api/Account.java similarity index 97% rename from src/main/java/io/github/ghacupha/keeper/book/Account.java rename to src/main/java/io/github/ghacupha/keeper/book/api/Account.java index 2c1142c..d8d94c0 100644 --- a/src/main/java/io/github/ghacupha/keeper/book/Account.java +++ b/src/main/java/io/github/ghacupha/keeper/book/api/Account.java @@ -14,7 +14,7 @@ * limitations under the License. */ -package io.github.ghacupha.keeper.book; +package io.github.ghacupha.keeper.book.api; import io.github.ghacupha.keeper.book.balance.AccountBalance; import io.github.ghacupha.keeper.book.unit.time.TimePoint; diff --git a/src/main/java/io/github/ghacupha/keeper/book/AccountAttributes.java b/src/main/java/io/github/ghacupha/keeper/book/api/AccountAttributes.java similarity index 98% rename from src/main/java/io/github/ghacupha/keeper/book/AccountAttributes.java rename to src/main/java/io/github/ghacupha/keeper/book/api/AccountAttributes.java index c7b76a0..4d6c875 100644 --- a/src/main/java/io/github/ghacupha/keeper/book/AccountAttributes.java +++ b/src/main/java/io/github/ghacupha/keeper/book/api/AccountAttributes.java @@ -14,7 +14,7 @@ * limitations under the License. */ -package io.github.ghacupha.keeper.book; +package io.github.ghacupha.keeper.book.api; import io.github.ghacupha.keeper.book.unit.money.Cash; import io.github.ghacupha.keeper.book.unit.time.TimePoint; diff --git a/src/main/java/io/github/ghacupha/keeper/book/Entry.java b/src/main/java/io/github/ghacupha/keeper/book/api/Entry.java similarity index 92% rename from src/main/java/io/github/ghacupha/keeper/book/Entry.java rename to src/main/java/io/github/ghacupha/keeper/book/api/Entry.java index 7c1dc2d..a4e2771 100644 --- a/src/main/java/io/github/ghacupha/keeper/book/Entry.java +++ b/src/main/java/io/github/ghacupha/keeper/book/api/Entry.java @@ -14,10 +14,10 @@ * limitations under the License. */ -package io.github.ghacupha.keeper.book; +package io.github.ghacupha.keeper.book.api; -import io.github.ghacupha.keeper.book.internal.AccountImpl; -import io.github.ghacupha.keeper.book.internal.EntryDetails; +import io.github.ghacupha.keeper.book.base.AccountImpl; +import io.github.ghacupha.keeper.book.base.EntryDetails; import io.github.ghacupha.keeper.book.unit.money.Cash; import io.github.ghacupha.keeper.book.unit.money.HardCash; import io.github.ghacupha.keeper.book.unit.time.TimePoint; diff --git a/src/main/java/io/github/ghacupha/keeper/book/EntryAttributes.java b/src/main/java/io/github/ghacupha/keeper/book/api/EntryAttributes.java similarity index 98% rename from src/main/java/io/github/ghacupha/keeper/book/EntryAttributes.java rename to src/main/java/io/github/ghacupha/keeper/book/api/EntryAttributes.java index 55d90a0..54f2d8f 100644 --- a/src/main/java/io/github/ghacupha/keeper/book/EntryAttributes.java +++ b/src/main/java/io/github/ghacupha/keeper/book/api/EntryAttributes.java @@ -14,7 +14,7 @@ * limitations under the License. */ -package io.github.ghacupha.keeper.book; +package io.github.ghacupha.keeper.book.api; import io.github.ghacupha.keeper.book.unit.money.Cash; diff --git a/src/main/java/io/github/ghacupha/keeper/book/Transaction.java b/src/main/java/io/github/ghacupha/keeper/book/api/Transaction.java similarity index 98% rename from src/main/java/io/github/ghacupha/keeper/book/Transaction.java rename to src/main/java/io/github/ghacupha/keeper/book/api/Transaction.java index 68de850..5cd0341 100644 --- a/src/main/java/io/github/ghacupha/keeper/book/Transaction.java +++ b/src/main/java/io/github/ghacupha/keeper/book/api/Transaction.java @@ -14,7 +14,7 @@ * limitations under the License. */ -package io.github.ghacupha.keeper.book; +package io.github.ghacupha.keeper.book.api; import io.github.ghacupha.keeper.book.unit.money.Cash; import io.github.ghacupha.keeper.book.util.ImmutableEntryException; diff --git a/src/main/java/io/github/ghacupha/keeper/book/internal/AccountDetails.java b/src/main/java/io/github/ghacupha/keeper/book/base/AccountDetails.java similarity index 97% rename from src/main/java/io/github/ghacupha/keeper/book/internal/AccountDetails.java rename to src/main/java/io/github/ghacupha/keeper/book/base/AccountDetails.java index aeac2f6..75fe6ee 100644 --- a/src/main/java/io/github/ghacupha/keeper/book/internal/AccountDetails.java +++ b/src/main/java/io/github/ghacupha/keeper/book/base/AccountDetails.java @@ -14,10 +14,10 @@ * limitations under the License. */ -package io.github.ghacupha.keeper.book.internal; +package io.github.ghacupha.keeper.book.base; -import io.github.ghacupha.keeper.book.Account; -import io.github.ghacupha.keeper.book.AccountAttributes; +import io.github.ghacupha.keeper.book.api.Account; +import io.github.ghacupha.keeper.book.api.AccountAttributes; import io.github.ghacupha.keeper.book.unit.money.Cash; import io.github.ghacupha.keeper.book.unit.time.TimePoint; diff --git a/src/main/java/io/github/ghacupha/keeper/book/internal/AccountImpl.java b/src/main/java/io/github/ghacupha/keeper/book/base/AccountImpl.java similarity index 96% rename from src/main/java/io/github/ghacupha/keeper/book/internal/AccountImpl.java rename to src/main/java/io/github/ghacupha/keeper/book/base/AccountImpl.java index 1214d2d..926977c 100644 --- a/src/main/java/io/github/ghacupha/keeper/book/internal/AccountImpl.java +++ b/src/main/java/io/github/ghacupha/keeper/book/base/AccountImpl.java @@ -14,11 +14,11 @@ * limitations under the License. */ -package io.github.ghacupha.keeper.book.internal; +package io.github.ghacupha.keeper.book.base; -import io.github.ghacupha.keeper.book.Account; -import io.github.ghacupha.keeper.book.AccountAttributes; -import io.github.ghacupha.keeper.book.Entry; +import io.github.ghacupha.keeper.book.api.Account; +import io.github.ghacupha.keeper.book.api.AccountAttributes; +import io.github.ghacupha.keeper.book.api.Entry; import io.github.ghacupha.keeper.book.balance.AccountBalance; import io.github.ghacupha.keeper.book.balance.AccountBalanceType; import io.github.ghacupha.keeper.book.unit.money.Cash; diff --git a/src/main/java/io/github/ghacupha/keeper/book/internal/AccountingEntry.java b/src/main/java/io/github/ghacupha/keeper/book/base/AccountingEntry.java similarity index 96% rename from src/main/java/io/github/ghacupha/keeper/book/internal/AccountingEntry.java rename to src/main/java/io/github/ghacupha/keeper/book/base/AccountingEntry.java index ceb0977..f76be03 100644 --- a/src/main/java/io/github/ghacupha/keeper/book/internal/AccountingEntry.java +++ b/src/main/java/io/github/ghacupha/keeper/book/base/AccountingEntry.java @@ -14,11 +14,11 @@ * limitations under the License. */ -package io.github.ghacupha.keeper.book.internal; +package io.github.ghacupha.keeper.book.base; -import io.github.ghacupha.keeper.book.Account; -import io.github.ghacupha.keeper.book.Entry; -import io.github.ghacupha.keeper.book.EntryAttributes; +import io.github.ghacupha.keeper.book.api.Account; +import io.github.ghacupha.keeper.book.api.Entry; +import io.github.ghacupha.keeper.book.api.EntryAttributes; import io.github.ghacupha.keeper.book.unit.money.Cash; import io.github.ghacupha.keeper.book.unit.money.HardCash; import io.github.ghacupha.keeper.book.unit.time.TimePoint; diff --git a/src/main/java/io/github/ghacupha/keeper/book/internal/AccountingTransaction.java b/src/main/java/io/github/ghacupha/keeper/book/base/AccountingTransaction.java similarity index 94% rename from src/main/java/io/github/ghacupha/keeper/book/internal/AccountingTransaction.java rename to src/main/java/io/github/ghacupha/keeper/book/base/AccountingTransaction.java index 97c8d46..df298e4 100644 --- a/src/main/java/io/github/ghacupha/keeper/book/internal/AccountingTransaction.java +++ b/src/main/java/io/github/ghacupha/keeper/book/base/AccountingTransaction.java @@ -14,12 +14,12 @@ * limitations under the License. */ -package io.github.ghacupha.keeper.book.internal; +package io.github.ghacupha.keeper.book.base; -import io.github.ghacupha.keeper.book.Account; -import io.github.ghacupha.keeper.book.Entry; -import io.github.ghacupha.keeper.book.EntryAttributes; -import io.github.ghacupha.keeper.book.Transaction; +import io.github.ghacupha.keeper.book.api.Account; +import io.github.ghacupha.keeper.book.api.Entry; +import io.github.ghacupha.keeper.book.api.EntryAttributes; +import io.github.ghacupha.keeper.book.api.Transaction; import io.github.ghacupha.keeper.book.unit.money.Cash; import io.github.ghacupha.keeper.book.unit.money.HardCash; import io.github.ghacupha.keeper.book.unit.time.TimePoint; diff --git a/src/main/java/io/github/ghacupha/keeper/book/internal/AccoutingEntryDecorator.java b/src/main/java/io/github/ghacupha/keeper/book/base/AccoutingEntryDecorator.java similarity index 85% rename from src/main/java/io/github/ghacupha/keeper/book/internal/AccoutingEntryDecorator.java rename to src/main/java/io/github/ghacupha/keeper/book/base/AccoutingEntryDecorator.java index 08021fe..01f5fb1 100644 --- a/src/main/java/io/github/ghacupha/keeper/book/internal/AccoutingEntryDecorator.java +++ b/src/main/java/io/github/ghacupha/keeper/book/base/AccoutingEntryDecorator.java @@ -14,11 +14,11 @@ * limitations under the License. */ -package io.github.ghacupha.keeper.book.internal; +package io.github.ghacupha.keeper.book.base; -import io.github.ghacupha.keeper.book.Account; -import io.github.ghacupha.keeper.book.Entry; -import io.github.ghacupha.keeper.book.EntryAttributes; +import io.github.ghacupha.keeper.book.api.Account; +import io.github.ghacupha.keeper.book.api.Entry; +import io.github.ghacupha.keeper.book.api.EntryAttributes; import io.github.ghacupha.keeper.book.unit.money.Cash; import io.github.ghacupha.keeper.book.unit.time.TimePoint; diff --git a/src/main/java/io/github/ghacupha/keeper/book/internal/EntryDetails.java b/src/main/java/io/github/ghacupha/keeper/book/base/EntryDetails.java similarity index 97% rename from src/main/java/io/github/ghacupha/keeper/book/internal/EntryDetails.java rename to src/main/java/io/github/ghacupha/keeper/book/base/EntryDetails.java index 7669373..470555d 100644 --- a/src/main/java/io/github/ghacupha/keeper/book/internal/EntryDetails.java +++ b/src/main/java/io/github/ghacupha/keeper/book/base/EntryDetails.java @@ -14,10 +14,10 @@ * limitations under the License. */ -package io.github.ghacupha.keeper.book.internal; +package io.github.ghacupha.keeper.book.base; -import io.github.ghacupha.keeper.book.Entry; -import io.github.ghacupha.keeper.book.EntryAttributes; +import io.github.ghacupha.keeper.book.api.Entry; +import io.github.ghacupha.keeper.book.api.EntryAttributes; import io.github.ghacupha.keeper.book.unit.money.Cash; import java.util.Map; diff --git a/src/main/java/io/github/ghacupha/keeper/book/internal/TransactionalEntry.java b/src/main/java/io/github/ghacupha/keeper/book/base/TransactionalEntry.java similarity index 84% rename from src/main/java/io/github/ghacupha/keeper/book/internal/TransactionalEntry.java rename to src/main/java/io/github/ghacupha/keeper/book/base/TransactionalEntry.java index 8b3e903..8738cfa 100644 --- a/src/main/java/io/github/ghacupha/keeper/book/internal/TransactionalEntry.java +++ b/src/main/java/io/github/ghacupha/keeper/book/base/TransactionalEntry.java @@ -14,12 +14,12 @@ * limitations under the License. */ -package io.github.ghacupha.keeper.book.internal; +package io.github.ghacupha.keeper.book.base; -import io.github.ghacupha.keeper.book.Account; -import io.github.ghacupha.keeper.book.Entry; -import io.github.ghacupha.keeper.book.EntryAttributes; -import io.github.ghacupha.keeper.book.Transaction; +import io.github.ghacupha.keeper.book.api.Account; +import io.github.ghacupha.keeper.book.api.Entry; +import io.github.ghacupha.keeper.book.api.EntryAttributes; +import io.github.ghacupha.keeper.book.api.Transaction; import io.github.ghacupha.keeper.book.unit.money.Cash; import io.github.ghacupha.keeper.book.unit.time.TimePoint; diff --git a/src/test/java/io/github/ghacupha/keeper/book/AccountTest.java b/src/test/java/io/github/ghacupha/keeper/book/AccountTest.java index becd83c..98d06b8 100644 --- a/src/test/java/io/github/ghacupha/keeper/book/AccountTest.java +++ b/src/test/java/io/github/ghacupha/keeper/book/AccountTest.java @@ -1,9 +1,13 @@ package io.github.ghacupha.keeper.book; -import io.github.ghacupha.keeper.book.internal.AccountDetails; -import io.github.ghacupha.keeper.book.internal.AccountImpl; -import io.github.ghacupha.keeper.book.internal.AccountingEntry; -import io.github.ghacupha.keeper.book.internal.EntryDetails; +import io.github.ghacupha.keeper.book.api.Account; +import io.github.ghacupha.keeper.book.api.AccountAttributes; +import io.github.ghacupha.keeper.book.api.Entry; +import io.github.ghacupha.keeper.book.api.EntryAttributes; +import io.github.ghacupha.keeper.book.base.AccountDetails; +import io.github.ghacupha.keeper.book.base.AccountImpl; +import io.github.ghacupha.keeper.book.base.AccountingEntry; +import io.github.ghacupha.keeper.book.base.EntryDetails; import io.github.ghacupha.keeper.book.unit.money.Cash; import io.github.ghacupha.keeper.book.unit.money.HardCash; import io.github.ghacupha.keeper.book.unit.time.Moment; diff --git a/src/test/java/io/github/ghacupha/keeper/book/EntryDetailsTest.java b/src/test/java/io/github/ghacupha/keeper/book/EntryDetailsTest.java index 32c2d04..5221281 100644 --- a/src/test/java/io/github/ghacupha/keeper/book/EntryDetailsTest.java +++ b/src/test/java/io/github/ghacupha/keeper/book/EntryDetailsTest.java @@ -16,7 +16,8 @@ package io.github.ghacupha.keeper.book; -import io.github.ghacupha.keeper.book.internal.EntryDetails; +import io.github.ghacupha.keeper.book.api.EntryAttributes; +import io.github.ghacupha.keeper.book.base.EntryDetails; import io.github.ghacupha.keeper.book.unit.money.HardCash; import org.junit.Before; import org.junit.Test; diff --git a/src/test/java/io/github/ghacupha/keeper/book/internal/AccountingTransactionTest.java b/src/test/java/io/github/ghacupha/keeper/book/base/AccountingTransactionTest.java similarity index 95% rename from src/test/java/io/github/ghacupha/keeper/book/internal/AccountingTransactionTest.java rename to src/test/java/io/github/ghacupha/keeper/book/base/AccountingTransactionTest.java index d7184b4..91ad5d3 100644 --- a/src/test/java/io/github/ghacupha/keeper/book/internal/AccountingTransactionTest.java +++ b/src/test/java/io/github/ghacupha/keeper/book/base/AccountingTransactionTest.java @@ -14,12 +14,12 @@ * limitations under the License. */ -package io.github.ghacupha.keeper.book.internal; +package io.github.ghacupha.keeper.book.base; -import io.github.ghacupha.keeper.book.Account; -import io.github.ghacupha.keeper.book.AccountAttributes; -import io.github.ghacupha.keeper.book.EntryAttributes; -import io.github.ghacupha.keeper.book.Transaction; +import io.github.ghacupha.keeper.book.api.Account; +import io.github.ghacupha.keeper.book.api.AccountAttributes; +import io.github.ghacupha.keeper.book.api.EntryAttributes; +import io.github.ghacupha.keeper.book.api.Transaction; import io.github.ghacupha.keeper.book.balance.AccountBalance; import io.github.ghacupha.keeper.book.unit.money.HardCash; import io.github.ghacupha.keeper.book.unit.time.Moment; From eee13eb5552c4968b862fab868c89e735279a58d Mon Sep 17 00:00:00 2001 From: Edwin Njeru Date: Wed, 21 Mar 2018 14:55:33 +0300 Subject: [PATCH 2/3] added missing module --- .travis.yml | 3 + pom.xml | 1102 +++++++---------- src/main/checkstyle/checkstyle.xml | 282 +++-- .../book/util/ImmutableEntryException.java | 4 +- .../util/MismatchedCurrencyException.java | 4 +- .../book/util/UnableToPostException.java | 4 +- .../util/UntimelyBookingDateException.java | 6 +- src/main/java/module-info.java | 7 + 8 files changed, 623 insertions(+), 789 deletions(-) create mode 100644 src/main/java/module-info.java diff --git a/.travis.yml b/.travis.yml index 66c78f5..e0b58e4 100644 --- a/.travis.yml +++ b/.travis.yml @@ -2,6 +2,9 @@ language: java install: true script: +- mvn checkstyle:check +- mvn checkstyle:checkstyle +- mvn verify - mvn compile - mvn package - mvn test diff --git a/pom.xml b/pom.xml index 5b45e2e..3954152 100644 --- a/pom.xml +++ b/pom.xml @@ -34,6 +34,13 @@ + + + 1.2-SNAPSHOT + book-keeper + + io.github.ghacupha.keeper.book.* + book-keeper dev UTF-8 UTF-8 @@ -55,6 +62,7 @@ 3.1.0 + 1.1 2.12.1 2.17 3.0.0 @@ -65,6 +73,8 @@ 1.6 2.5.2 3.0.2 + 3.5.0 + 1.6.0 3.0.0-M1 2.5 3.5 @@ -72,25 +82,33 @@ 2.9 2.4 3.0.2 + 1.1.2-SNAPSHOT 3.4 3.0.1 2.20.1 2.20.1 - 1.1 0.7.9 3.1.0-RC6 - 1.8 + + - false + true true none + ${project.basedir}/src/main/checkstyle/checkstyle.xml + true + true + false + false + false + false false @@ -102,204 +120,265 @@ https://github.com/ghacupha/book-keeper + + Travis CI + https://travis-ci.org/ghacupha/book-keeper + + + + + sonatype-nexus + Sonatype Nexus Snapshots + https://oss.sonatype.org/content/repositories/snapshots + + + + - all-tests - - all-tests - - false - false - - - - dev - - - integration-test + java6and7 + + [1.6,1.8) + - - integration-test - - false - true + true + - travis + java6and7and8 - - env.TRAVIS - true - + [1.6,9) + - org.jacoco - jacoco-maven-plugin + org.apache.maven.plugins + maven-compiler-plugin + + + module-info.java + + + - org.eluder.coveralls - coveralls-maven-plugin + org.apache.maven.plugins + maven-javadoc-plugin + + + module-info.java + + + + + + + org.apache.maven.plugins maven-javadoc-plugin + + + module-info.java + + + + + + + + + java9plus + + [9,) + + + + + + org.apache.maven.plugins + maven-compiler-plugin + - attach-javadocs + default-compile + + 9 + + + + + base-compile - jar + compile + + + module-info.java + + + + + + 9 + + ${book-keeper.release.version} + + org.apache.maven.plugins - maven-source-plugin - ${maven-source-plugin.version} + maven-dependency-plugin - attach-sources + copy-dependencies + compile - jar + copy-dependencies + + ${project.build.directory}/dependencies + true + true + + + + org.apache.maven.plugins + maven-javadoc-plugin + + --module-path ${project.build.directory}/dependencies + + + + + + + org.apache.maven.plugins + maven-javadoc-plugin + ${maven-javadoc-plugin.version} + + --module-path ${project.build.directory}/dependencies + + + + + - release-sign-artifacts + repo-sign-artifacts - performRelease - true + oss.repo + org.apache.maven.plugins - maven-source-plugin - 3.0.1 + maven-enforcer-plugin + ${maven-enforcer-plugin.version} - attach-sources + enforce-java - jar-no-fork + enforce + + + + [9,) + + + + org.apache.maven.plugins - maven-javadoc-plugin - 2.10.4 + maven-gpg-plugin - attach-javadocs + sign-artifacts + verify - jar + sign + org.apache.maven.plugins - maven-gpg-plugin - 1.6 + maven-assembly-plugin + + false + + src/main/assembly/dist.xml + + gnu + - sign-artifacts - verify + make-assembly + install - sign + single - - - - - documentation - - + + + - org.asciidoctor - asciidoctor-maven-plugin - 1.5.6 - - - org.asciidoctor - asciidoctorj-pdf - 1.5.0-alpha.16 - - + de.jutzig + github-release-plugin + ${github-release-plugin.version} - src/main/asciidoc - ${project.basedir} - src/main/asciidoc/images/ - true - + Release v${project.version} + v${project.version} + true + + + ${project.build.directory} + + ${book-keeper.artifactId}*-dist.tar.gz + ${book-keeper.artifactId}*-dist.zip + + + - output-html - prepare-package - - process-asciidoc - - - target/docs - coderay - html - - - - output-pdf - prepare-package + github-releases + deploy - process-asciidoc + release - - pdf - - coderay - - - - - - - - + + + - - Travis CI - https://travis-ci.org/ghacupha/book-keeper - - - - - sonatype-nexus - Sonatype Nexus Snapshots - https://oss.sonatype.org/content/repositories/snapshots - - - - install - src/main/resources @@ -313,186 +392,32 @@ - - - - org.apache.maven.wagon - wagon-ssh - 2.4 - - - org.apache.maven.wagon - wagon-webdav-jackrabbit - 2.2 - - - - - - - org.codehaus.mojo - versions-maven-plugin - 2.5 - - - org.apache.maven.plugins - maven-release-plugin - 2.5.3 - - - - org.apache.maven.plugins - maven-enforcer-plugin - - - enforce-versions - - enforce - - - - - 3.5.0 - - - 1.8.0 - - - - true - true - true - - - - - - - - - - - - org.apache.felix - maven-bundle-plugin - 2.5.3 - true - - - org.apache.maven.plugins - maven-jar-plugin - 3.0.2 - - - org.jacoco - jacoco-maven-plugin - 0.7.2.201409121644 - - - prepare-agent - - prepare-agent - - - - - - - + - - - org.sonatype.plugins - nexus-staging-maven-plugin - 1.6.8 - true - - sonatype-nexus - https://oss.sonatype.org/ - true - - - - org.apache.maven.plugins - maven-release-plugin - - true - false - release - deploy - - + org.apache.maven.plugins - maven-compiler-plugin - ${maven-compiler-plugin.version} - - ${maven.compiler.source} - ${maven.compiler.target} - ${maven.compiler.fork} - ${maven.compiler.executable} - - - - org.codehaus.mojo - build-helper-maven-plugin - 1.7 + maven-enforcer-plugin - - add-integration-test-sources - generate-test-sources + enforce-maven - add-test-source + enforce - - - src/integration-test/java - + + + 3.5.0 + + - - org.apache.maven.plugins - maven-resources-plugin - 3.0.2 - - ${project.build.sourceEncoding} - - org.apache.maven.plugins maven-checkstyle-plugin - ${maven-checkstyle-plugin.version} run-checkstyle @@ -503,38 +428,10 @@ - module-info.java - - org.apache.maven.plugins - maven-failsafe-plugin - 2.21.0 - - - - integration-tests - - integration-test - verify - - - - ${failsafeArgLine} - - - ${it.skip} - - - - + org.apache.maven.plugins maven-jar-plugin @@ -545,19 +442,43 @@ true true + + ${book-keeper.module.name} + - - + + + org.apache.felix + maven-bundle-plugin + 2.5.4 + + + biz.aQute.bnd + biz.aQute.bndlib + 3.5.0 + + + + + bundle-manifest + process-classes + + manifest + + + + ${book-keeper.osgi.packages} + + + + + + org.apache.maven.plugins maven-javadoc-plugin - 3.0.0 - - private - true - attach-javadocs @@ -568,12 +489,10 @@ - org.apache.maven.plugins maven-source-plugin - ${maven-source-plugin.version} attach-sources @@ -584,172 +503,238 @@ - + - org.apache.maven.plugins - maven-pdf-plugin - 1.4 - - - pdf - site - - pdf - - - ${project.reporting.outputDirectory} - true - - - + com.github.spotbugs + spotbugs-maven-plugin + ${spotbugs-maven-plugin.version} + + + com.github.spotbugs + spotbugs + 3.1.0 + + + org.jacoco jacoco-maven-plugin - 0.7.5.201505241946 + ${jacoco-maven-plugin.version} - - pre-unit-test + jacoco-initialize prepare-agent - - - ${jacoco.ut.execution.data.file} - - surefireArgLine - - - post-unit-test - test - - report - - - - ${jacoco.ut.execution.data.file} - - ${project.reporting.outputDirectory}/jacoco-ut - - - - - pre-integration-test - pre-integration-test - - prepare-agent - - - - ${jacoco.it.execution.data.file} - - failsafeArgLine - - - - - post-integration-test - post-integration-test + jacoco-site + package report - - - ${jacoco.it.execution.data.file} - - ${project.reporting.outputDirectory}/jacoco-it - + org.apache.maven.plugins - maven-surefire-plugin - 2.21.0 + maven-site-plugin - - ${surefireArgLine} - - ${skip.unit.tests} - - - **/IT*.java - + true - - - org.codehaus.mojo - cobertura-maven-plugin - 2.6 - - ${basedir}/target - xml - 256m - - true - - - - - org.apache.felix - maven-bundle-plugin - 2.5.4 - biz.aQute.bnd - biz.aQute.bndlib - 3.5.0 + lt.velykis.maven.skins + reflow-velocity-tools + 1.1.1 + + + org.apache.velocity + velocity + 1.7 - - - bundle-manifest - process-classes - - manifest - - - - + - org.codehaus.mojo - exec-maven-plugin - 1.4.0 + com.github.github + site-maven-plugin + 0.12 + github-site - java + site + site-deploy + + Create website for ${project.artifactId} v${project.version} + ${project.artifactId} + true + github + Edwin Njeru + io.github.ghacupha.keeper.book + refs/heads/master + + + + org.apache.maven.plugins + maven-compiler-plugin + + 9 + 9 + + + + + + + org.apache.maven.plugins + maven-assembly-plugin + ${maven-assembly-plugin.version} + + + org.apache.maven.plugins + maven-checkstyle-plugin + ${maven-checkstyle-plugin.version} + + + org.apache.maven.plugins + maven-changes-plugin + ${maven-changes-plugin.version} + + + org.apache.maven.plugins + maven-clean-plugin + ${maven-clean-plugin.version} + + + org.apache.maven.plugins + maven-compiler-plugin + ${maven-compiler-plugin.version} + + + org.apache.maven.plugins + maven-deploy-plugin + ${maven-deploy-plugin.version} + + + org.apache.maven.plugins + maven-dependency-plugin + ${maven-dependency-plugin.version} + + + org.apache.maven.plugins + maven-enforcer-plugin + ${maven-enforcer-plugin.version} + + + org.apache.maven.plugins + maven-gpg-plugin + ${maven-gpg-plugin.version} + + + org.apache.maven.plugins + maven-install-plugin + ${maven-install-plugin.version} + + + org.apache.maven.plugins + maven-jar-plugin + ${maven-jar-plugin.version} + + + org.apache.maven.plugins + maven-javadoc-plugin + ${maven-javadoc-plugin.version} + + + org.apache.maven.plugins + maven-jxr-plugin + ${maven-jxr-plugin.version} + + + org.apache.maven.plugins + maven-plugin-plugin + ${maven-plugin-plugin.version} + + + org.apache.maven.plugins + maven-pmd-plugin + ${maven-pmd-plugin.version} + + + org.apache.maven.plugins + maven-project-info-reports-plugin + ${maven-project-info-reports-plugin.version} + + + org.apache.maven.plugins + maven-repository-plugin + ${maven-repository-plugin.version} + + + org.apache.maven.plugins + maven-resources-plugin + ${maven-resources-plugin.version} + + + org.apache.maven.plugins + maven-site-plugin + ${maven-site-plugin.version} + + + org.apache.maven.plugins + maven-source-plugin + ${maven-source-plugin.version} + + + org.apache.maven.plugins + maven-surefire-plugin + ${maven-surefire-plugin.version} + + + org.apache.maven.plugins + maven-surefire-report-plugin + ${maven-surefire-report-plugin.version} + + + org.apache.maven.plugins + maven-toolchains-plugin + ${maven-toolchains-plugin.version} + + + org.eclipse.m2e + lifecycle-mapping + 1.0.0 + + + + + + org.apache.felix + maven-bundle-plugin + [2.5.4,) + + manifest + + + + + + + + + + + + @@ -856,44 +841,6 @@ - - - spring-snapshots - Spring Snapshots - https://repo.spring.io/snapshot - - true - - - - spring-milestones - Spring Milestones - https://repo.spring.io/milestone - - false - - - - - - - spring-snapshots - Spring Snapshots - https://repo.spring.io/snapshot - - true - - - - spring-milestones - Spring Milestones - https://repo.spring.io/milestone - - false - - - - @@ -913,164 +860,33 @@ 4.12 compile - - - - + + + central + Maven Repository Switchboard + default + http://repo1.maven.org/maven2 + + false + + + + + + + central + Maven Plugin Repository + http://repo1.maven.org/maven2 + default + + false + + + never + + + diff --git a/src/main/checkstyle/checkstyle.xml b/src/main/checkstyle/checkstyle.xml index b7d1d83..00ddd9d 100644 --- a/src/main/checkstyle/checkstyle.xml +++ b/src/main/checkstyle/checkstyle.xml @@ -2,141 +2,151 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/src/main/java/io/github/ghacupha/keeper/book/util/ImmutableEntryException.java b/src/main/java/io/github/ghacupha/keeper/book/util/ImmutableEntryException.java index 7687c7d..1a2607b 100644 --- a/src/main/java/io/github/ghacupha/keeper/book/util/ImmutableEntryException.java +++ b/src/main/java/io/github/ghacupha/keeper/book/util/ImmutableEntryException.java @@ -16,8 +16,8 @@ package io.github.ghacupha.keeper.book.util; -import io.github.ghacupha.keeper.book.Entry; -import io.github.ghacupha.keeper.book.EntryAttributes; +import io.github.ghacupha.keeper.book.api.Entry; +import io.github.ghacupha.keeper.book.api.EntryAttributes; /** * Exception thrown when {@link EntryAttributes} are added to an {@link Entry} after the {@link Entry} has been set diff --git a/src/main/java/io/github/ghacupha/keeper/book/util/MismatchedCurrencyException.java b/src/main/java/io/github/ghacupha/keeper/book/util/MismatchedCurrencyException.java index 5ec7fb9..5a6cdbf 100644 --- a/src/main/java/io/github/ghacupha/keeper/book/util/MismatchedCurrencyException.java +++ b/src/main/java/io/github/ghacupha/keeper/book/util/MismatchedCurrencyException.java @@ -16,9 +16,7 @@ package io.github.ghacupha.keeper.book.util; -import io.github.ghacupha.keeper.book.Account; -import io.github.ghacupha.keeper.book.Entry; -import io.github.ghacupha.keeper.book.Transaction; +import io.github.ghacupha.keeper.book.api.*; import java.util.Currency; diff --git a/src/main/java/io/github/ghacupha/keeper/book/util/UnableToPostException.java b/src/main/java/io/github/ghacupha/keeper/book/util/UnableToPostException.java index 7e6100c..ef8c0ab 100644 --- a/src/main/java/io/github/ghacupha/keeper/book/util/UnableToPostException.java +++ b/src/main/java/io/github/ghacupha/keeper/book/util/UnableToPostException.java @@ -16,8 +16,8 @@ package io.github.ghacupha.keeper.book.util; -import io.github.ghacupha.keeper.book.Entry; -import io.github.ghacupha.keeper.book.internal.AccountingTransaction; +import io.github.ghacupha.keeper.book.api.Entry; +import io.github.ghacupha.keeper.book.base.AccountingTransaction; /** * This exception is thrown when the {@link AccountingTransaction} client diff --git a/src/main/java/io/github/ghacupha/keeper/book/util/UntimelyBookingDateException.java b/src/main/java/io/github/ghacupha/keeper/book/util/UntimelyBookingDateException.java index 2c0d49e..c502fc7 100644 --- a/src/main/java/io/github/ghacupha/keeper/book/util/UntimelyBookingDateException.java +++ b/src/main/java/io/github/ghacupha/keeper/book/util/UntimelyBookingDateException.java @@ -16,9 +16,9 @@ package io.github.ghacupha.keeper.book.util; -import io.github.ghacupha.keeper.book.Account; -import io.github.ghacupha.keeper.book.Entry; -import io.github.ghacupha.keeper.book.internal.AccountDetails; +import io.github.ghacupha.keeper.book.api.Account; +import io.github.ghacupha.keeper.book.api.Entry; +import io.github.ghacupha.keeper.book.base.AccountDetails; import io.github.ghacupha.keeper.book.unit.time.TimePoint; /** diff --git a/src/main/java/module-info.java b/src/main/java/module-info.java new file mode 100644 index 0000000..e788566 --- /dev/null +++ b/src/main/java/module-info.java @@ -0,0 +1,7 @@ +module book.keeper { + requires slf4j.api; + requires joda.money; + + exports io.github.ghacupha.keeper.book.api; + exports io.github.ghacupha.keeper.book.base; +} \ No newline at end of file From 89ba7c8106eb68d213c1a8c4afaf7eb8b983f404 Mon Sep 17 00:00:00 2001 From: Edwin Njeru Date: Wed, 21 Mar 2018 15:29:59 +0300 Subject: [PATCH 3/3] reconfiguration of the project object model --- pom.xml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/pom.xml b/pom.xml index 3954152..a8ed75b 100644 --- a/pom.xml +++ b/pom.xml @@ -45,15 +45,15 @@ UTF-8 UTF-8 1.8 + 1.8 + 1.8 + 1.8 false false -Dapp.env=LOCAL -Dapp.domain=localhost -Dapp.port=9901 -Dapp.env=LOCAL -Dapp.domain=localhost -Dapp.port=9901 - 9 - 9 - 9 - javac9 + true 2.12.1 "documentation" @@ -225,9 +225,9 @@ - 9 + ${maven.compiler.source} - ${book-keeper.release.version} + 9 @@ -585,8 +585,8 @@ org.apache.maven.plugins maven-compiler-plugin - 9 - 9 + ${maven.compiler.source} + ${maven.compiler.target}