From 4df9ed110eb4cf3bc73caed913cbace9f44f66d9 Mon Sep 17 00:00:00 2001 From: Gesa HENTSCHKE Date: Thu, 18 Apr 2024 10:07:43 +0200 Subject: [PATCH] [#866] code cleanup fixes #866 --- .../preferences/GenericEditorPreferencePage.java | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/bundles/org.eclipse.ui.genericeditor/src/org/eclipse/ui/internal/genericeditor/preferences/GenericEditorPreferencePage.java b/bundles/org.eclipse.ui.genericeditor/src/org/eclipse/ui/internal/genericeditor/preferences/GenericEditorPreferencePage.java index f28ebaf7a50..4f7c5cfe1c3 100644 --- a/bundles/org.eclipse.ui.genericeditor/src/org/eclipse/ui/internal/genericeditor/preferences/GenericEditorPreferencePage.java +++ b/bundles/org.eclipse.ui.genericeditor/src/org/eclipse/ui/internal/genericeditor/preferences/GenericEditorPreferencePage.java @@ -21,7 +21,6 @@ import org.eclipse.core.runtime.Platform; import org.eclipse.core.runtime.preferences.PreferenceMetadata; import org.eclipse.jface.dialogs.Dialog; -import org.eclipse.jface.dialogs.DialogPage; import org.eclipse.jface.dialogs.IMessageProvider; import org.eclipse.jface.layout.GridDataFactory; import org.eclipse.jface.preference.IPreferenceStore; @@ -193,13 +192,9 @@ private static String validateDelay(String value) { private void updateStatus(String errorMessage) { setValid(errorMessage == null); - applyToStatusLine(this, errorMessage); - } - - private static void applyToStatusLine(DialogPage page, String errorMessage) { var messageType = errorMessage == null ? IMessageProvider.NONE : IMessageProvider.ERROR; - page.setMessage(errorMessage, messageType); - page.setErrorMessage(errorMessage); + setMessage(errorMessage, messageType); + setErrorMessage(errorMessage); } private static int parseInteger(Object value) throws NumberFormatException {